Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2461113002: WebUI: Make settings-action-menu re-usable as cr-action-menu. (Closed)
Patch Set: getComputedStyle instead of util.js Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html
index 14f7e4d6976e66c94119b264bad92299bcd8aab2..8ce101def13e6509053d65056bc18d08dc07932e 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/languages_page.html
@@ -5,6 +5,7 @@
<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action_menu.html">
<link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expand_button.html">
<link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_render.html">
<link rel="import" href="chrome://resources/cr_elements/icons.html">
@@ -12,7 +13,6 @@
<link rel="import" href="/languages_page/languages.html">
<link rel="import" href="/lifetime_browser_proxy.html">
<link rel="import" href="/route.html">
-<link rel="import" href="/settings_action_menu.html">
<link rel="import" href="/settings_page/settings_animated_pages.html">
<link rel="import" href="/settings_page/settings_subpage.html">
<link rel="import" href="/settings_shared_css.html">
@@ -39,15 +39,15 @@
margin-top: 4px;
}
- dialog[is='settings-action-menu'].complex .dropdown-item {
+ dialog[is='cr-action-menu'].complex .dropdown-item {
min-height: 36px;
}
- dialog[is='settings-action-menu']:not(.complex) hr {
+ dialog[is='cr-action-menu']:not(.complex) hr {
display: none;
}
- dialog[is='settings-action-menu'].complex hr {
+ dialog[is='cr-action-menu'].complex hr {
/* Override user-agent border and margin. */
border: none;
/* TODO(michaelpg): Update to whatever variable is used for the darker,
@@ -193,7 +193,7 @@
</iron-collapse>
</if>
<template is="cr-lazy-render" id="menu">
- <dialog is="settings-action-menu"
+ <dialog is="cr-action-menu"
class$="[[getMenuClass_(prefs.translate.enabled.value)]]">
<if expr="chromeos or is_win">
<paper-checkbox id="uiLanguageItem" class="dropdown-item"

Powered by Google App Engine
This is Rietveld 408576698