Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2461083002:
Fix uninitialized memory bug from scaling addition (Closed)
DescriptionFix uninitialized memory bug from scaling addition
|scale_factor_| was not initialized in PrintSettings::Clear()
function like the other elements of PrintSettings. Fixed by initializing
the value to default (1.0). Uninitialized value was introduced
in commit https://chromium.googlesource.com/chromium/src/+/769ffdf779d83399a6f219e2637c6469ab94da0e
BUG=659594
Committed: https://crrev.com/614913eb9d85a921dc84ee66d72e128af2c23f3a
Cr-Commit-Position: refs/heads/master@{#428550}
Patch Set 1 #
Messages
Total messages: 20 (15 generated)
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Description was changed from ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in print_settings in Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). BUG=659594 ========== to ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in print_settings in Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). BUG=659594 ==========
rbpotter@chromium.org changed reviewers: + thestig@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm In the commit message, I would mention the commit number where the uninit value got added, for future reference.
Description was changed from ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in print_settings in Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). BUG=659594 ========== to ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in PrintSettings::Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). Uninitialized value was introduced in issue 2240433003. BUG=659594 ==========
Description was changed from ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in PrintSettings::Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). Uninitialized value was introduced in issue 2240433003. BUG=659594 ========== to ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in PrintSettings::Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). Uninitialized value was introduced in commit https://chromium.googlesource.com/chromium/src/+/769ffdf779d83399a6f219e2637c... BUG=659594 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in PrintSettings::Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). Uninitialized value was introduced in commit https://chromium.googlesource.com/chromium/src/+/769ffdf779d83399a6f219e2637c... BUG=659594 ========== to ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in PrintSettings::Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). Uninitialized value was introduced in commit https://chromium.googlesource.com/chromium/src/+/769ffdf779d83399a6f219e2637c... BUG=659594 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in PrintSettings::Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). Uninitialized value was introduced in commit https://chromium.googlesource.com/chromium/src/+/769ffdf779d83399a6f219e2637c... BUG=659594 ========== to ========== Fix uninitialized memory bug from scaling addition |scale_factor_| was not initialized in PrintSettings::Clear() function like the other elements of PrintSettings. Fixed by initializing the value to default (1.0). Uninitialized value was introduced in commit https://chromium.googlesource.com/chromium/src/+/769ffdf779d83399a6f219e2637c... BUG=659594 Committed: https://crrev.com/614913eb9d85a921dc84ee66d72e128af2c23f3a Cr-Commit-Position: refs/heads/master@{#428550} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/614913eb9d85a921dc84ee66d72e128af2c23f3a Cr-Commit-Position: refs/heads/master@{#428550} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
