Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2461073002: Use MediaCodec.setOutputSurface() for fullscreen transitions on M. (Closed)
Patch Set: Address comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/surface_manager.h ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 52e99201235acd0f7dbe6f617a9c2403600d4240..7c07127938336be403e28ca96ada3e980106deb4 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -280,7 +280,8 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// Called by GpuVideoDecoder on Android to request a surface to render to (if
// necessary).
- void OnSurfaceRequested(const SurfaceCreatedCB& surface_created_cb);
+ void OnSurfaceRequested(bool decoder_requires_restart_for_overlay,
+ const SurfaceCreatedCB& surface_created_cb);
// Creates a Renderer via the |renderer_factory_|.
std::unique_ptr<Renderer> CreateRenderer();
@@ -526,8 +527,10 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
int overlay_surface_id_;
// If a surface is requested before it's finished being created, the request
- // is saved and satisfied once the surface is available.
- SurfaceCreatedCB pending_surface_request_cb_;
+ // is saved and satisfied once the surface is available. If the decoder does
+ // not require restart to change surfaces, this is callback is kept until
+ // cleared by the decoder.
+ SurfaceCreatedCB set_surface_cb_;
// Force to use SurfaceView instead of SurfaceTexture on Android.
bool force_video_overlays_;
« no previous file with comments | « media/base/surface_manager.h ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698