Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

Issue 2461073002: Use MediaCodec.setOutputSurface() for fullscreen transitions on M. (Closed)
Patch Set: Rework logic. Fix nits. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/android/sdk_media_codec_bridge.h » ('j') | media/blink/webmediaplayer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
diff --git a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
index 089581cea862eabc44ac432ae0901d5fb7be156b..56c309658d260b7ffa8145d674734c89f901fc60 100644
--- a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
+++ b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
@@ -620,6 +620,16 @@ class MediaCodecBridge {
}
}
+ @TargetApi(Build.VERSION_CODES.M)
+ @CalledByNative
+ private void setSurface(Surface surface) {
+ try {
+ mMediaCodec.setOutputSurface(surface);
+ } catch (IllegalArgumentException | IllegalStateException e) {
+ Log.e(TAG, "Cannot set output surface", e);
+ }
watk 2016/11/08 22:59:03 Seems like this should return an error? If we fail
DaleCurtis 2016/11/08 23:50:10 Done.
+ }
+
@CalledByNative
private static void setFrameHasADTSHeader(MediaFormat format) {
format.setInteger(MediaFormat.KEY_IS_ADTS, 1);
« no previous file with comments | « no previous file | media/base/android/sdk_media_codec_bridge.h » ('j') | media/blink/webmediaplayer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698