[chromium-reviews] Fix for BrowserActions load/unload not changing Omnibox length. BrowserAction...

Fix for BrowserActions UNLOAD not changing Omnibox length. BrowserActionsContainer is the child view of ToolBarView. When BrowserActionsContainer gets notification for LOAD/UNLOAD, it needs to re-layout ToolBarView, its parent.

BUG=23381
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28190

[Erik does not do reviews, 2009-10-06 21:53:04]

LGTM

On Tue, Oct 6, 2009 at 2:33 PM,  <sidchat@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Description:
> Fix for BrowserActions UNLOAD not changing Omnibox length.
> BrowserActionsContainer is the child view of ToolBarView. When
> BrowserActionsContainer gets notification for LOAD/UNLOAD, it needs to
> re-layout
> ToolBarView, its parent.
>
> BUG=3D23381
> TEST=3Dnone
>
>
> Please review this at http://codereview.chromium.org/246107
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/views/browser_actions_container.cc
>
>
> Index: chrome/browser/views/browser_actions_container.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/views/browser_actions_container.cc =A0 (revision 28005=
)
> +++ chrome/browser/views/browser_actions_container.cc =A0 (working copy)
> @@ -375,6 +375,9 @@
> =A0 =A0 =A0 type =3D=3D NotificationType::EXTENSION_UNLOADED ||
> =A0 =A0 =A0 type =3D=3D NotificationType::EXTENSION_UNLOADED_DISABLED) {
> =A0 =A0 RefreshBrowserActionViews();
> +
> + =A0 =A0// All these actions may change visibility of BrowserActions.
> + =A0 =A0OnBrowserActionVisibilityChanged();
> =A0 } else {
> =A0 =A0 NOTREACHED() << L"Received unexpected notification";
> =A0 }
> @@ -413,7 +416,7 @@
> =A0 }
> =A0}
>
> -void BrowserActionsContainer::PaintBadge(gfx::Canvas* canvas,
> +void BrowserActionsContainer::PaintBadge(gfx::Canvas* canvas,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0BrowserActionImageView* view,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0const SkColor& badge_color,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0const std::string& text) {
>
>
>