Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2461053002: Center Keyboard Overlay in the work area (Closed)

Created:
4 years, 1 month ago by afakhry
Modified:
4 years, 1 month ago
Reviewers:
James Cook
CC:
chromium-reviews, jam, darin-cc_chromium.org, sadrul, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Center Keyboard Overlay in the work area This is to avoid overlapping with the shelf when it's set to auto hide. BUG=658307 TEST=Keyboard overlay should be in the center of the screen. TEST=ash_content_unittests --gtest_filter=ShelfAlignmentAny* Committed: https://crrev.com/75c698249ed690540336ef9ee71cefa44e77f4e6 Cr-Commit-Position: refs/heads/master@{#428730}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ash/content/keyboard_overlay/keyboard_overlay_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
afakhry
James, could you please review? Thank you!
4 years, 1 month ago (2016-10-28 19:53:41 UTC) #2
James Cook
LGTM. Nice CL description by the way. Concise yet complete.
4 years, 1 month ago (2016-10-28 21:00:40 UTC) #3
afakhry
On 2016/10/28 21:00:40, James Cook wrote: > LGTM. Nice CL description by the way. Concise ...
4 years, 1 month ago (2016-10-28 21:36:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461053002/1
4 years, 1 month ago (2016-10-28 21:37:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/262602)
4 years, 1 month ago (2016-10-28 22:16:47 UTC) #8
afakhry
Sorry I overlooked the tests.
4 years, 1 month ago (2016-10-29 00:53:42 UTC) #12
James Cook
still lgtm
4 years, 1 month ago (2016-10-31 15:45:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461053002/20001
4 years, 1 month ago (2016-10-31 15:52:35 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 16:21:00 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 16:45:44 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75c698249ed690540336ef9ee71cefa44e77f4e6
Cr-Commit-Position: refs/heads/master@{#428730}

Powered by Google App Engine
This is Rietveld 408576698