Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2461043003: Fix for the RedirectTest.ClientServerServer test. (Closed)
Patch Set: More build error fixes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 800e38378e8e596430318731ed891abd4ee6ce16..5586500b5d70cd1c7c3037aee47a610f63d63385 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -220,7 +220,8 @@ void FrameLoader::init() {
? WebURLRequest::FrameTypeTopLevel
: WebURLRequest::FrameTypeNested);
m_provisionalDocumentLoader =
- client()->createDocumentLoader(m_frame, initialRequest, SubstituteData());
+ client()->createDocumentLoader(m_frame, initialRequest, SubstituteData(),
+ ClientRedirectPolicy::NotClientRedirect);
m_provisionalDocumentLoader->startLoadingMainResource();
m_frame->document()->cancelParsing();
m_stateMachine.advanceTo(
@@ -1658,14 +1659,11 @@ void FrameLoader::startLoad(FrameLoadRequest& frameLoadRequest,
m_provisionalDocumentLoader = client()->createDocumentLoader(
m_frame, request, frameLoadRequest.substituteData().isValid()
? frameLoadRequest.substituteData()
- : defaultSubstituteDataForURL(request.url()));
+ : defaultSubstituteDataForURL(request.url()),
+ frameLoadRequest.clientRedirect());
m_provisionalDocumentLoader->setNavigationType(navigationType);
m_provisionalDocumentLoader->setReplacesCurrentHistoryItem(
type == FrameLoadTypeReplaceCurrentItem);
- m_provisionalDocumentLoader->setIsClientRedirect(
- frameLoadRequest.clientRedirect() ==
- ClientRedirectPolicy::ClientRedirect);
-
m_frame->navigationScheduler().cancel();
m_checkTimer.stop();
@@ -1675,8 +1673,6 @@ void FrameLoader::startLoad(FrameLoadRequest& frameLoadRequest,
client()->dispatchWillSubmitForm(frameLoadRequest.form());
m_progressTracker->progressStarted();
- if (m_provisionalDocumentLoader->isClientRedirect())
- m_provisionalDocumentLoader->appendRedirect(m_frame->document()->url());
m_provisionalDocumentLoader->appendRedirect(
m_provisionalDocumentLoader->request().url());
double triggeringEventTime =

Powered by Google App Engine
This is Rietveld 408576698