Fix for the RedirectTest.ClientServerServer test.

third_party/WebKit/Source/core/loader/FrameLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) Research In Motion Limited 2009. All rights reserved.
  * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>
  * Copyright (C) 2011 Google Inc. All rights reserved.
@@ skipping 1657 matching lines @@
 
   m_frame->navigationScheduler().cancel();
   m_checkTimer.stop();
 
   m_loadType = type;
 
   if (frameLoadRequest.form())
     client()->dispatchWillSubmitForm(frameLoadRequest.form());
 
   m_progressTracker->progressStarted();
+  // The document URL needs to be added to the head of the list as that is
+  // where the redirects originated.
   if (m_provisionalDocumentLoader->isClientRedirect())
-    m_provisionalDocumentLoader->appendRedirect(m_frame->document()->url());
+    m_provisionalDocumentLoader->prependRedirect(m_frame->document()->url());

[nasko, 2016/10/31 18:45:50]

Why is there another URL in the redirect chain? The m_provisionalDocumentLoader
is constructed on 1658 and the m_redirectChain should be empty at this point,
which is why just calling appendRedirect should've just worked.

[ananta, 2016/10/31 19:11:33]

The FrameLoaderClientImpl::createDocumentLoader function internally calls
RenderFrameImpl::didCreateDataSource which adds redirects to the list. It is not
empty as a result.

https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?q=...

   m_provisionalDocumentLoader->appendRedirect(
       m_provisionalDocumentLoader->request().url());
   double triggeringEventTime =
       frameLoadRequest.triggeringEvent()
           ? frameLoadRequest.triggeringEvent()->platformTimeStamp()
           : 0;
   client()->dispatchDidStartProvisionalLoad(triggeringEventTime);
   DCHECK(m_provisionalDocumentLoader);
   m_provisionalDocumentLoader->startLoadingMainResource();
 
@@ skipping 239 matching lines @@
                          m_documentLoader ? m_documentLoader->url() : String());
   return tracedValue;
 }
 
 inline void FrameLoader::takeObjectSnapshot() const {
   TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID("loading", "FrameLoader", this,
                                       toTracedValue());
 }
 
 }  // namespace blink