Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2461033002: Fix the VDA unittest to pass texture ids in the correct order (Closed)

Created:
4 years, 1 month ago by watk
Modified:
4 years, 1 month ago
Reviewers:
wuchengli
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the VDA unittest to pass texture ids in the correct order A recent change cleaned up the naming and ordering of the client and service texture ids in PictureBuffer and the VDA layers, but the test wasn't updated. Now the test VDA client passes the texture ids as service ids, because that's what they are. BUG=660389 Committed: https://crrev.com/83ae56bab030686ec47692edf2243dfcd680e7a7 Cr-Commit-Position: refs/heads/master@{#428610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/video_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
watk
PTAL
4 years, 1 month ago (2016-10-28 19:24:58 UTC) #5
wuchengli
lgtm
4 years, 1 month ago (2016-10-29 09:00:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461033002/1
4 years, 1 month ago (2016-10-29 09:01:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-29 09:05:31 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 09:07:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83ae56bab030686ec47692edf2243dfcd680e7a7
Cr-Commit-Position: refs/heads/master@{#428610}

Powered by Google App Engine
This is Rietveld 408576698