Reduce GPU mailbox size to 16 bytes

Reduce GPU mailbox size to 16 bytes

16 bytes is enough entropy. This is a precursor to replacing gpu::Mailbox by
base::UnguessableToken (which is 16 bytes).

BUG=660138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e
Cr-Commit-Position: refs/heads/master@{#428881}

[piman, 2016-10-29 00:19:27]

Description was changed from

==========
Reduce GPU mailbox size to 16 bytes

16 bytes is enough entropy. This is a precursor to replacing gpu::Mailbox by
base::UnguessableToken (which is 16 bytes).

BUG=660138
==========

to

==========
Reduce GPU mailbox size to 16 bytes

16 bytes is enough entropy. This is a precursor to replacing gpu::Mailbox by
base::UnguessableToken (which is 16 bytes).

BUG=660138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-10-29 00:20:34]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-29 00:20:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-10-29 00:22:38]

piman@chromium.org changed reviewers:
+ dcheng@chromium.org, zmo@chromium.org

[piman, 2016-10-29 00:22:38]

zmo: please review
dcheng: gpu/ipc and overall security soundness

[Zhenyao Mo, 2016-10-29 00:27:46]

On 2016/10/29 00:22:38, piman wrote:
> zmo: please review
> dcheng: gpu/ipc and overall security soundness

lgtm

[dcheng, 2016-10-29 00:32:23]

ipc lgtm

https://codereview.chromium.org/2461003003/diff/1/gpu/GLES2/gl2extchromium.h
File gpu/GLES2/gl2extchromium.h (right):

https://codereview.chromium.org/2461003003/diff/1/gpu/GLES2/gl2extchromium.h#...
gpu/GLES2/gl2extchromium.h:22: #define GL_MAILBOX_SIZE_CHROMIUM 16
Unrelated, but we could probably make this a constexpr not-macro thing now.

[piman, 2016-10-29 00:33:57]

On Fri, Oct 28, 2016 at 5:32 PM, <dcheng@chromium.org> wrote:

> ipc lgtm
>
>
> https://codereview.chromium.org/2461003003/diff/1/gpu/
> GLES2/gl2extchromium.h
> File gpu/GLES2/gl2extchromium.h (right):
>
> https://codereview.chromium.org/2461003003/diff/1/gpu/
> GLES2/gl2extchromium.h#newcode22
> gpu/GLES2/gl2extchromium.h:22: #define GL_MAILBOX_SIZE_CHROMIUM 16
> Unrelated, but we could probably make this a constexpr not-macro thing
> now.
>

This file is intended to be included from C so I'll leave it in the C way
(despite all the problems that it causes).


>
> https://codereview.chromium.org/2461003003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[piman, 2016-10-29 00:34:11]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-10-29 00:34:13]

The CQ bit was checked by piman@chromium.org

[piman, 2016-10-29 00:34:19]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-10-29 00:34:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-10-29 00:39:28]

The CQ bit was checked by piman@chromium.org

[piman, 2016-10-29 00:39:29]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2461003003/#ps20001
(title: "fix tests")

[commit-bot: I haz the power, 2016-10-29 00:39:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 01:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 01:52:01]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[piman, 2016-10-31 22:55:43]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:56:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 00:26:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 00:29:40]

Description was changed from

==========
Reduce GPU mailbox size to 16 bytes

16 bytes is enough entropy. This is a precursor to replacing gpu::Mailbox by
base::UnguessableToken (which is 16 bytes).

BUG=660138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reduce GPU mailbox size to 16 bytes

16 bytes is enough entropy. This is a precursor to replacing gpu::Mailbox by
base::UnguessableToken (which is 16 bytes).

BUG=660138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e
Cr-Commit-Position: refs/heads/master@{#428881}
==========

[commit-bot: I haz the power, 2016-11-01 00:29:41]

Patchset 2 (id:??) landed as
https://crrev.com/02b9c4e04a6c4fbcee7d3a6902145a43110bff1e
Cr-Commit-Position: refs/heads/master@{#428881}