Issue 2461002: - Begin removing [static] qualifier from methods in Bootstrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2461002: - Begin removing [static] qualifier from methods in Bootstrapper. (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

- Begin removing [static] qualifier from methods in Bootstrapper. Committed: http://code.google.com/p/v8/source/detail?r=4775

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -25 lines)			Patch
M	src/api.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/bootstrapper.h	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	src/debug.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8threads.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 6 months ago (2010-06-01 21:37:19 UTC) #2

LGTM.


This patch made me realize we need a way to tell functions that should stay
static from the ones we just haven't converted yet (in a particular class).
Let's discuss this tomorrow.


-- Vitaly

Expand Messages | Collapse Messages