Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Previously LayoutSVGRoot inherited the function from LayoutReplaced
which assumes the object always has something to paint for itself
and always returns false. However, LayoutSVGRoot should use the
same rule as LayoutBox. When a LayoutSVGRoot doesn't have box
decorations, it doesn't need any paint invalidation for itself.

BUG=660195
Committed: https://crrev.com/fbb39cf2f2de761f01d273049c150719a231cdff
Cr-Commit-Position: refs/heads/master@{#428588}

[Xianzhu, 2016-10-28 18:34:56]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-10-28 18:36:56]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-10-28 18:36:56]

I have run it locally and all layout test mismatches are removal of unnecessary
paint invalidation of empty (by itself, not including descendants) SVG roots.
Will rebaseline the tests after it finishes running on try bots.

[Xianzhu, 2016-10-28 18:55:22]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:55:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-10-28 19:21:33]

On 2016/10/28 at 18:36:56, wangxianzhu wrote:
> I have run it locally and all layout test mismatches are removal of
unnecessary paint invalidation of empty (by itself, not including descendants)
SVG roots. Will rebaseline the tests after it finishes running on try bots.

LGTM

[Xianzhu, 2016-10-28 19:33:53]

Description was changed from

==========
Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Previously LayoutSVGRoot inherits the function from LayoutReplaced
which assumes the object always has something to paint for itself
and always returns false. However, LayoutSVGRoot should use the
same rule as LayoutBox. When a LayoutSVGRoot doesn't have box
decorations, it doesn't need any paint invalidation for itself.

BUG=660195
==========

to

==========
Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Previously LayoutSVGRoot inherited the function from LayoutReplaced
which assumes the object always has something to paint for itself
and always returns false. However, LayoutSVGRoot should use the
same rule as LayoutBox. When a LayoutSVGRoot doesn't have box
decorations, it doesn't need any paint invalidation for itself.

BUG=660195
==========

[commit-bot: I haz the power, 2016-10-28 20:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 20:18:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-10-28 21:47:05]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-28 21:47:06]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2460983002/#ps40001
(title: "Rebaseline-cl")

[commit-bot: I haz the power, 2016-10-28 21:47:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-10-28 22:33:41]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-28 22:33:42]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2460983002/#ps60001
(title: "Remove an extra file (rebaseline-cl seems to add untracked files under
LayoutTests)")

[commit-bot: I haz the power, 2016-10-28 22:34:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 22:51:00]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xianzhu, 2016-10-29 00:44:56]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-29 00:44:56]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2460983002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-29 00:45:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 01:58:53]

Description was changed from

==========
Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Previously LayoutSVGRoot inherited the function from LayoutReplaced
which assumes the object always has something to paint for itself
and always returns false. However, LayoutSVGRoot should use the
same rule as LayoutBox. When a LayoutSVGRoot doesn't have box
decorations, it doesn't need any paint invalidation for itself.

BUG=660195
==========

to

==========
Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Previously LayoutSVGRoot inherited the function from LayoutReplaced
which assumes the object always has something to paint for itself
and always returns false. However, LayoutSVGRoot should use the
same rule as LayoutBox. When a LayoutSVGRoot doesn't have box
decorations, it doesn't need any paint invalidation for itself.

BUG=660195
==========

[commit-bot: I haz the power, 2016-10-29 01:58:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-29 02:04:26]

Description was changed from

==========
Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Previously LayoutSVGRoot inherited the function from LayoutReplaced
which assumes the object always has something to paint for itself
and always returns false. However, LayoutSVGRoot should use the
same rule as LayoutBox. When a LayoutSVGRoot doesn't have box
decorations, it doesn't need any paint invalidation for itself.

BUG=660195
==========

to

==========
Use LayoutBox::paintedOutputOfObjectHasNoEffectregardlessOfSize() for SVGRoot

Previously LayoutSVGRoot inherited the function from LayoutReplaced
which assumes the object always has something to paint for itself
and always returns false. However, LayoutSVGRoot should use the
same rule as LayoutBox. When a LayoutSVGRoot doesn't have box
decorations, it doesn't need any paint invalidation for itself.

BUG=660195

Committed: https://crrev.com/fbb39cf2f2de761f01d273049c150719a231cdff
Cr-Commit-Position: refs/heads/master@{#428588}
==========

[commit-bot: I haz the power, 2016-10-29 02:04:28]

Patchset 5 (id:??) landed as
https://crrev.com/fbb39cf2f2de761f01d273049c150719a231cdff
Cr-Commit-Position: refs/heads/master@{#428588}