Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5195)

Unified Diff: chrome/browser/sync/engine/net/gaia_authenticator.h

Issue 246098: Sync: Remove pthreads from auth_watcher. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/net/gaia_authenticator.h
===================================================================
--- chrome/browser/sync/engine/net/gaia_authenticator.h (revision 28272)
+++ chrome/browser/sync/engine/net/gaia_authenticator.h (working copy)
@@ -105,7 +105,7 @@
// This object should only be invoked from the AuthWatcherThread message
// loop, which is injected here.
- void set_message_loop(MessageLoop* loop) {
+ void set_message_loop(const MessageLoop* loop) {
message_loop_ = loop;
}
@@ -181,9 +181,10 @@
// The real Authenticate implementations.
bool AuthenticateImpl(const AuthParams& params);
bool AuthenticateImpl(const AuthParams& params, AuthResults* results);
- bool PerformGaiaRequest(const AuthParams& params, AuthResults* results);
// virtual for testing purposes.
+ virtual bool PerformGaiaRequest(const AuthParams& params,
+ AuthResults* results);
virtual bool Post(const GURL& url, const std::string& post_body,
unsigned long* response_code, std::string* response_body) {
return false;
@@ -191,7 +192,7 @@
// Caller should fill in results->LSID before calling. Result in
// results->primary_email.
- bool LookupEmail(AuthResults* results);
+ virtual bool LookupEmail(AuthResults* results);
public:
// Retrieve email.
@@ -288,7 +289,7 @@
// The message loop all our methods are invoked on. Generally this is the
// SyncEngine_AuthWatcherThread's message loop.
- MessageLoop* message_loop_;
+ const MessageLoop* message_loop_;
};
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/engine/auth_watcher_unittest.cc ('k') | chrome/browser/sync/engine/net/server_connection_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698