Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/isolate.cc

Issue 2460973003: [Tracing] Use TracingCategoryObserver in runtime statistics (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler-dispatcher/compiler-dispatcher-tracer.cc ('K') | « src/ic/ic.cc ('k') | src/log.cc » ('j') | src/log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index cafe546191bba737b06692b79d23808ec40feee5..afcc496963aa375d49411aec3008542e37c279b3 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -9,6 +9,7 @@
#include <fstream> // NOLINT(readability/streams)
#include <sstream>
+#include "include/v8-tracing.h"
#include "src/ast/context-slot-cache.h"
#include "src/base/hashmap.h"
#include "src/base/platform/platform.h"
@@ -2737,8 +2738,8 @@ void Isolate::DumpAndResetCompilationStats() {
turbo_statistics_ = nullptr;
delete hstatistics_;
hstatistics_ = nullptr;
- if (FLAG_runtime_call_stats &&
- !TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_ENABLED()) {
+ if (!(FLAG_runtime_stats ^
+ v8::tracing::TracingCategoryObserver::ENABLED_BY_NATIVE)) {
Camillo Bruni 2016/10/31 09:39:41 Isn't this just "FLAG_runtime_stats == v8::tracing
lpy 2016/10/31 17:28:02 Done.
OFStream os(stdout);
counters()->runtime_call_stats()->Print(os);
counters()->runtime_call_stats()->Reset();
« src/compiler-dispatcher/compiler-dispatcher-tracer.cc ('K') | « src/ic/ic.cc ('k') | src/log.cc » ('j') | src/log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698