gpu, cmaa: reuse CopyTextureCHROMIUMResourceManager

gpu/command_buffer/tests/gl_apply_screen_space_antialiasing_CHROMIUM_unittest.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GL_GLEXT_PROTOTYPES
 #define GL_GLEXT_PROTOTYPES
 #endif
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
@@ skipping 119 matching lines @@
 
   glBindFramebuffer(GL_FRAMEBUFFER, 0);
   glApplyScreenSpaceAntialiasingCHROMIUM();
   EXPECT_EQ(static_cast<GLenum>(GL_INVALID_OPERATION), glGetError());
 }
 
 TEST_F(GLApplyScreenSpaceAntialiasingCHROMIUMTest, InternalFormat) {
   if (!available_)
     return;
 
-  GLint formats[] = {GL_RGB, GL_RGBA};
+  GLint formats[] = {GL_RGB, GL_RGBA, GL_ALPHA, GL_LUMINANCE,
+                     GL_LUMINANCE_ALPHA};
   for (size_t index = 0; index < arraysize(formats); index++) {
     glTexImage2D(GL_TEXTURE_2D, 0, formats[index], 1, 1, 0, formats[index],
                  GL_UNSIGNED_BYTE, nullptr);
     EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
 
     glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D,
                            textures_, 0);
 
+    // Only if the format is supported by FBO, supported by this extension.
+    if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE)
+      continue;
+
     glClear(GL_COLOR_BUFFER_BIT);
+    EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
 
     glApplyScreenSpaceAntialiasingCHROMIUM();
     EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError()) << "index:"
                                                               << index;
 
     uint8_t pixels[1 * 4] = {0u, 255u, 0u, 255u};
     GLTestHelper::CheckPixels(0, 0, 1, 1, 0, pixels);
     EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
   }
 }
 
-TEST_F(GLApplyScreenSpaceAntialiasingCHROMIUMTest, InternalFormatNotSupported) {
-  if (!available_)
-    return;
-
-  // Check unsupported format reports error.
-  GLint unsupported_formats[] = {GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA};
-  for (size_t index = 0; index < arraysize(unsupported_formats); index++) {
-    glTexImage2D(GL_TEXTURE_2D, 0, unsupported_formats[index], 1, 1, 0,
-                 unsupported_formats[index], GL_UNSIGNED_BYTE, nullptr);
-    EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
-
-    glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D,
-                           textures_, 0);
-
-    glClear(GL_COLOR_BUFFER_BIT);
-
-    glApplyScreenSpaceAntialiasingCHROMIUM();
-    EXPECT_EQ(static_cast<GLenum>(GL_INVALID_FRAMEBUFFER_OPERATION),
-              glGetError())
-        << "index:" << index;
-  }
-}
-
 TEST_F(GLApplyScreenSpaceAntialiasingCHROMIUMTest, ImmutableTexture) {
   if (!available_)
     return;
 
   if (!GLTestHelper::HasExtension("GL_EXT_texture_storage")) {
     LOG(INFO) << "GL_EXT_texture_storage not supported. Skipping test...";
     return;
   }
   GLenum internal_formats[] = {GL_RGB8_OES, GL_RGBA8_OES, GL_BGRA8_EXT};
   for (auto internal_format : internal_formats) {
@@ skipping 237 matching lines @@
   EXPECT_TRUE(GLTestHelper::CheckPixels(0, 0, 1, 1, 0, expected));
 
   EXPECT_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
 
   gl2.MakeCurrent();
   gl2.Destroy();
   gl_.MakeCurrent();
 }
 
 }  // namespace gpu