Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: gpu/config/gpu_blacklist_unittest.cc

Issue 2460943002: Lower ES3 capable requirement to GL 3.3 with extensions. (Closed)
Patch Set: fix win build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/config/gpu_blacklist_unittest.cc
diff --git a/gpu/config/gpu_blacklist_unittest.cc b/gpu/config/gpu_blacklist_unittest.cc
index 420a4fbc4fafa91ec70df0bce8b58923d5e0a262..71a0e7ce4ddf7c39e77a08742868d077e946d2d5 100644
--- a/gpu/config/gpu_blacklist_unittest.cc
+++ b/gpu/config/gpu_blacklist_unittest.cc
@@ -79,6 +79,15 @@ TEST_F(GpuBlacklistTest, CurrentBlacklistValidation) {
std::unique_ptr<GpuBlacklist> blacklist(GpuBlacklist::Create());
EXPECT_TRUE(blacklist->LoadList(
kSoftwareRenderingListJson, GpuBlacklist::kAllOs));
+
+ // Check with a fake GPU with GL version 3.3, WebGL2 is blacklisted on Mac.
+ GPUInfo gpu_info;
+ gpu_info.gpu.vendor_id = 0x1234;
+ gpu_info.gpu.device_id = 0x5678;
+ gpu_info.gl_version = "3.3";
+ std::set<int> type = blacklist->MakeDecision(
+ GpuBlacklist::kOsMacosx, kOsVersion, gpu_info);
+ EXPECT_EQ(1u, type.count(GPU_FEATURE_TYPE_WEBGL2));
}
TEST_F(GpuBlacklistTest, DuplicatedIDValidation) {
@@ -137,4 +146,8 @@ GPU_BLACKLIST_FEATURE_TEST(AcceleratedVpxDecode,
"accelerated_vpx_decode",
GPU_FEATURE_TYPE_ACCELERATED_VPX_DECODE)
+GPU_BLACKLIST_FEATURE_TEST(WebGL2,
+ "webgl2",
+ GPU_FEATURE_TYPE_WEBGL2)
+
} // namespace gpu

Powered by Google App Engine
This is Rietveld 408576698