Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: components/sync/device_info/device_info_sync_bridge.h

Issue 2460903003: [Sync] Rename DeviceInfoService to DeviceInfoSyncBridge. (Closed)
Patch Set: Removed 'USS' from a comment. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/device_info/device_info_sync_bridge.h
diff --git a/components/sync/device_info/device_info_service.h b/components/sync/device_info/device_info_sync_bridge.h
similarity index 89%
rename from components/sync/device_info/device_info_service.h
rename to components/sync/device_info/device_info_sync_bridge.h
index 48e1cc03c2eacdce61e363739c94c21a4441883b..6783586c6d12d50ca10e8dc9674ccbfeddd3d731 100644
--- a/components/sync/device_info/device_info_service.h
+++ b/components/sync/device_info/device_info_sync_bridge.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SERVICE_H_
-#define COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SERVICE_H_
+#ifndef COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SYNC_BRIDGE_H_
+#define COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SYNC_BRIDGE_H_
#include <stdint.h>
@@ -32,18 +32,19 @@ namespace syncer {
class ModelTypeChangeProcessor;
class SyncError;
-// USS service implementation for DEVICE_INFO model type. Handles storage of
+// Sync bridge implementation for DEVICE_INFO model type. Handles storage of
// device info and associated sync metadata, applying/merging foreign changes,
// and allows public read access.
-class DeviceInfoService : public ModelTypeSyncBridge, public DeviceInfoTracker {
+class DeviceInfoSyncBridge : public ModelTypeSyncBridge,
+ public DeviceInfoTracker {
public:
typedef base::Callback<void(const ModelTypeStore::InitCallback& callback)>
StoreFactoryFunction;
- DeviceInfoService(LocalDeviceInfoProvider* local_device_info_provider,
- const StoreFactoryFunction& callback,
- const ChangeProcessorFactory& change_processor_factory);
- ~DeviceInfoService() override;
+ DeviceInfoSyncBridge(LocalDeviceInfoProvider* local_device_info_provider,
+ const StoreFactoryFunction& callback,
+ const ChangeProcessorFactory& change_processor_factory);
+ ~DeviceInfoSyncBridge() override;
// ModelTypeSyncBridge implementation.
std::unique_ptr<MetadataChangeList> CreateMetadataChangeList() override;
@@ -69,7 +70,7 @@ class DeviceInfoService : public ModelTypeSyncBridge, public DeviceInfoTracker {
int CountActiveDevices() const override;
private:
- friend class DeviceInfoServiceTest;
+ friend class DeviceInfoSyncBridgeTest;
// Cache of all syncable and local data, stored by device cache guid.
using ClientIdToSpecifics =
@@ -152,9 +153,9 @@ class DeviceInfoService : public ModelTypeSyncBridge, public DeviceInfoTracker {
// Used to update our local device info once every pulse interval.
base::OneShotTimer pulse_timer_;
- DISALLOW_COPY_AND_ASSIGN(DeviceInfoService);
+ DISALLOW_COPY_AND_ASSIGN(DeviceInfoSyncBridge);
};
} // namespace syncer
-#endif // COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SERVICE_H_
+#endif // COMPONENTS_SYNC_DEVICE_INFO_DEVICE_INFO_SYNC_BRIDGE_H_

Powered by Google App Engine
This is Rietveld 408576698