Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2460903003: [Sync] Rename DeviceInfoService to DeviceInfoSyncBridge. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, mac-reviews_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename DeviceInfoService to DeviceInfoSyncBridge. BUG=660072 Committed: https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6 Cr-Commit-Position: refs/heads/master@{#428633}

Patch Set 1 #

Patch Set 2 : Removed 'USS' from a comment. #

Total comments: 2

Patch Set 3 : Updating nullptr to null in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -1621 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
D components/sync/device_info/device_info_service.h View 1 2 1 chunk +0 lines, -158 lines 0 comments Download
D components/sync/device_info/device_info_service.cc View 1 chunk +0 lines, -491 lines 0 comments Download
D components/sync/device_info/device_info_service_unittest.cc View 1 chunk +0 lines, -761 lines 0 comments Download
A + components/sync/device_info/device_info_sync_bridge.h View 1 2 4 chunks +12 lines, -11 lines 0 comments Download
A + components/sync/device_info/device_info_sync_bridge.cc View 21 chunks +51 lines, -49 lines 0 comments Download
A + components/sync/device_info/device_info_sync_bridge_unittest.cc View 1 2 20 chunks +138 lines, -138 lines 0 comments Download
M components/sync/device_info/device_info_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (10 generated)
skym
PTAL.
4 years, 1 month ago (2016-10-28 21:32:43 UTC) #4
maxbogue
lgtm https://codereview.chromium.org/2460903003/diff/20001/components/sync/device_info/device_info_sync_bridge_unittest.cc File components/sync/device_info/device_info_sync_bridge_unittest.cc (right): https://codereview.chromium.org/2460903003/diff/20001/components/sync/device_info/device_info_sync_bridge_unittest.cc#newcode300 components/sync/device_info/device_info_sync_bridge_unittest.cc:300: // A non-owning pointer to the processor given ...
4 years, 1 month ago (2016-10-28 21:39:57 UTC) #5
skym
https://codereview.chromium.org/2460903003/diff/20001/components/sync/device_info/device_info_sync_bridge_unittest.cc File components/sync/device_info/device_info_sync_bridge_unittest.cc (right): https://codereview.chromium.org/2460903003/diff/20001/components/sync/device_info/device_info_sync_bridge_unittest.cc#newcode300 components/sync/device_info/device_info_sync_bridge_unittest.cc:300: // A non-owning pointer to the processor given to ...
4 years, 1 month ago (2016-10-28 21:52:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460903003/40001
4 years, 1 month ago (2016-10-28 22:48:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/58172)
4 years, 1 month ago (2016-10-28 23:14:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460903003/40001
4 years, 1 month ago (2016-10-28 23:32:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/262366)
4 years, 1 month ago (2016-10-28 23:50:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460903003/40001
4 years, 1 month ago (2016-10-30 21:37:05 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-30 22:38:39 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-30 22:40:41 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/559dd9e6e4f395e21cf5b186bdfa35caf2a0fdb6
Cr-Commit-Position: refs/heads/master@{#428633}

Powered by Google App Engine
This is Rietveld 408576698