Implement support for fake bold/italics for non-GDI windows font path

Implement support for fake bold/italics for non-GDI windows font path

Add plumbing for fake bold/italics to the windows non-GDI font path
and pass the values along to skia.

BUG=249099
R=bungeman@chromium.org, schenney@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158380

[bungeman-chromium, 2013-09-25 16:49:02]

lgtm

[commit-bot: I haz the power, 2013-09-25 17:00:44]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[eae, 2013-09-25 17:04:06]

Need a review from a full blink comitter.

[Stephen Chennney, 2013-09-25 20:50:21]

lgtm

[eae, 2013-09-25 23:01:43]

On 2013/09/25 20:50:21, Stephen Chenney wrote:
> lgtm

Thanks Stephen!

[commit-bot: I haz the power, 2013-09-25 23:32:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/24609002/1

[commit-bot: I haz the power, 2013-09-26 15:00:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/24609002/1

[commit-bot: I haz the power, 2013-09-26 15:00:46]

Failed to apply patch for
Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
  Hunk #1 FAILED at 56.
  Hunk #2 succeeded at 168 (offset 23 lines).
  Hunk #3 succeeded at 181 (offset 23 lines).
  Hunk #4 succeeded at 194 (offset 23 lines).
  Hunk #5 succeeded at 207 (offset 23 lines).
  Hunk #6 succeeded at 220 (offset 23 lines).
  Hunk #7 succeeded at 233 (offset 23 lines).
  Hunk #8 succeeded at 246 (offset 23 lines).
  Hunk #9 succeeded at 269 (offset 23 lines).
  1 out of 9 hunks FAILED -- saving rejects to file
Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp.rej

Patch:      
Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
Index: Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
diff --git
a/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
b/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
index
30f96c67ca626dc6fb0f209be72d796cdf567fe7..78b0ca8896466515555cd8ae70b1e86798bc5818
100644
--- a/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
+++ b/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
@@ -56,6 +56,8 @@ void FontPlatformData::setupPaint(SkPaint* paint) const
     const float ts = m_size >= 0 ? m_size : 12;
     paint->setTextSize(SkFloatToScalar(m_size));
     paint->setTypeface(typeface());
+    paint->setFakeBoldText(m_fakeBold);
+    paint->setTextSkewX(m_fakeItalic ? -SK_Scalar1 / 4 : 0);
 }
 #endif
 
@@ -145,6 +147,8 @@ PassRefPtr<SkTypeface> CreateTypefaceFromHFont(HFONT hfont,
int* size, int* pain
 FontPlatformData::FontPlatformData(WTF::HashTableDeletedValueType)
     : m_font(0)
     , m_size(-1)
+    , m_fakeBold(false)
+    , m_fakeItalic(false)
     , m_orientation(Horizontal)
     , m_scriptCache(0)
     , m_typeface(SkTypeface::RefDefault())
@@ -156,6 +160,8 @@
FontPlatformData::FontPlatformData(WTF::HashTableDeletedValueType)
 FontPlatformData::FontPlatformData()
     : m_font(0)
     , m_size(0)
+    , m_fakeBold(false)
+    , m_fakeItalic(false)
     , m_orientation(Horizontal)
     , m_scriptCache(0)
     , m_typeface(SkTypeface::RefDefault())
@@ -167,6 +173,8 @@ FontPlatformData::FontPlatformData()
 FontPlatformData::FontPlatformData(HFONT font, float size, FontOrientation
orientation)
     : m_font(RefCountedHFONT::create(font))
     , m_size(size)
+    , m_fakeBold(false)
+    , m_fakeItalic(false)
     , m_orientation(orientation)
     , m_scriptCache(0)
     , m_typeface(CreateTypefaceFromHFont(font, 0, &m_paintTextFlags))
@@ -178,6 +186,8 @@ FontPlatformData::FontPlatformData(HFONT font, float size,
FontOrientation orien
 FontPlatformData::FontPlatformData(float size, bool bold, bool oblique)
     : m_font(0)
     , m_size(size)
+    , m_fakeBold(false)
+    , m_fakeItalic(false)
     , m_orientation(Horizontal)
     , m_scriptCache(0)
     , m_typeface(SkTypeface::RefDefault())
@@ -189,6 +199,8 @@ FontPlatformData::FontPlatformData(float size, bool bold,
bool oblique)
 FontPlatformData::FontPlatformData(const FontPlatformData& data)
     : m_font(data.m_font)
     , m_size(data.m_size)
+    , m_fakeBold(false)
+    , m_fakeItalic(false)
     , m_orientation(data.m_orientation)
     , m_scriptCache(0)
     , m_typeface(data.m_typeface)
@@ -200,6 +212,8 @@ FontPlatformData::FontPlatformData(const FontPlatformData&
data)
 FontPlatformData::FontPlatformData(const FontPlatformData& data, float
textSize)
     : m_font(data.m_font)
     , m_size(textSize)
+    , m_fakeBold(false)
+    , m_fakeItalic(false)
     , m_orientation(data.m_orientation)
     , m_scriptCache(0)
     , m_typeface(data.m_typeface)
@@ -211,6 +225,8 @@ FontPlatformData::FontPlatformData(const FontPlatformData&
data, float textSize)
 FontPlatformData::FontPlatformData(SkTypeface* tf, const char* family, float
textSize, bool fakeBold, bool fakeItalic, FontOrientation orientation)
     : m_font(0)
     , m_size(textSize)
+    , m_fakeBold(fakeBold)
+    , m_fakeItalic(fakeItalic)
     , m_orientation(orientation)
     , m_scriptCache(0)
     , m_typeface(tf)
@@ -232,6 +248,8 @@ FontPlatformData& FontPlatformData::operator=(const
FontPlatformData& data)
     if (this != &data) {
         m_font = data.m_font;
         m_size = data.m_size;
+        m_fakeBold = data.m_fakeBold;
+        m_fakeItalic = data.m_fakeItalic;
         m_orientation = data.m_orientation;
         m_typeface = data.m_typeface;
         m_paintTextFlags = data.m_paintTextFlags;

[commit-bot: I haz the power, 2013-09-26 16:32:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/24609002/14001

[eae, 2013-09-26 16:37:54]

Committed patchset #2 manually as r158380 (presubmit successful).