Propagate location bar focus state when attaching to a NewTabPageView.

Init search box animation for NTP based on location bar focus state.

Because the focus is now set when attaching, the existing code in onDetachedFromWindow() can now be removed, which also fixes another issue (https://crbug.com/635424#c13).

BUG=659521, 635424
Committed: https://crrev.com/b193b850bec1cfb529bc027fec99870224ea0094
Cr-Commit-Position: refs/heads/master@{#428399}

[Bernhard Bauer, 2016-10-28 10:46:13]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 10:46:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-10-28 11:32:59]

Description was changed from

==========
Propagate location bar focus state when attaching to a NewTabPageView.

BUG=659521
==========

to

==========
Propagate location bar focus state when attaching to a NewTabPageView.

Because the focus is now set when attaching, the existing code in
onDetachedFromWindow() can now be removed, which also fixes another issue
(https://crbug.com/635424#c13).

BUG=659521,635424
==========

[Bernhard Bauer, 2016-10-28 11:38:53]

bauerb@chromium.org changed reviewers:
+ mdjones@chromium.org, peconn@chromium.org

[Bernhard Bauer, 2016-10-28 11:38:53]

Please review.

(+Ted FYI -- the old onDetachedFromWindow() code dates back quite a lot, so I'm
not completely sure about the rationale. I did test various tab-opening and
tab-switching changes, and it looked fine to me.)

[commit-bot: I haz the power, 2016-10-28 11:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 11:39:13]

Dry run: This issue passed the CQ dry run.

[PEConn, 2016-10-28 14:25:35]

On 2016/10/28 11:38:53, Bernhard Bauer wrote:
> Please review.
> 
> (+Ted FYI -- the old onDetachedFromWindow() code dates back quite a lot, so
I'm
> not completely sure about the rationale. I did test various tab-opening and
> tab-switching changes, and it looked fine to me.)

LGTM

[mdjones, 2016-10-28 15:42:33]

lgtm, but can you make the description a little more clear? Namely the code
doesn't seem to be propagating the focused state explicitly and doesn't seem to
be bound to view attaching code. Maybe something like: "Init location bar
animation for NTP based on focus state"

[Bernhard Bauer, 2016-10-28 17:00:29]

Description was changed from

==========
Propagate location bar focus state when attaching to a NewTabPageView.

Because the focus is now set when attaching, the existing code in
onDetachedFromWindow() can now be removed, which also fixes another issue
(https://crbug.com/635424#c13).

BUG=659521,635424
==========

to

==========
Init search box animation for NTP based on location bar focus state.

Because the focus is now set when attaching, the existing code in
onDetachedFromWindow() can now be removed, which also fixes another issue
(https://crbug.com/635424#c13).

BUG=659521,635424
==========

[Bernhard Bauer, 2016-10-28 17:01:13]

On 2016/10/28 15:42:33, mdjones wrote:
> lgtm, but can you make the description a little more clear? Namely the code
> doesn't seem to be propagating the focused state explicitly and doesn't seem
to
> be bound to view attaching code. Maybe something like: "Init location bar
> animation for NTP based on focus state"

Done!

[Bernhard Bauer, 2016-10-28 17:01:17]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-10-28 17:02:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 17:07:35]

Description was changed from

==========
Init search box animation for NTP based on location bar focus state.

Because the focus is now set when attaching, the existing code in
onDetachedFromWindow() can now be removed, which also fixes another issue
(https://crbug.com/635424#c13).

BUG=659521,635424
==========

to

==========
Init search box animation for NTP based on location bar focus state.

Because the focus is now set when attaching, the existing code in
onDetachedFromWindow() can now be removed, which also fixes another issue
(https://crbug.com/635424#c13).

BUG=659521,635424
==========

[commit-bot: I haz the power, 2016-10-28 17:07:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-28 17:22:00]

Description was changed from

==========
Init search box animation for NTP based on location bar focus state.

Because the focus is now set when attaching, the existing code in
onDetachedFromWindow() can now be removed, which also fixes another issue
(https://crbug.com/635424#c13).

BUG=659521,635424
==========

to

==========
Init search box animation for NTP based on location bar focus state.

Because the focus is now set when attaching, the existing code in
onDetachedFromWindow() can now be removed, which also fixes another issue
(https://crbug.com/635424#c13).

BUG=659521,635424

Committed: https://crrev.com/b193b850bec1cfb529bc027fec99870224ea0094
Cr-Commit-Position: refs/heads/master@{#428399}
==========

[commit-bot: I haz the power, 2016-10-28 17:22:01]

Patchset 1 (id:??) landed as
https://crrev.com/b193b850bec1cfb529bc027fec99870224ea0094
Cr-Commit-Position: refs/heads/master@{#428399}