Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2460843002: Revert of Allow image documents in MHT if there is only one resource. (Closed)

Created:
4 years, 1 month ago by phoglund_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow image documents in MHT if there is only one resource. (patchset #3 id:40001 of https://codereview.chromium.org/2425863002/ ) Reason for revert: This changelist re-enables a bunch of tests that fail (they report Missing): https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/16490 Please write explicitly that you're re-enabling tests in the CL description next time, that would have made sheriffing much easier. The CL description only mentions re-ordering some logic and not that it's also re-enabling tests. Original issue's description: > Allow image documents in MHT if there is only one resource. > > MHTML could not show image documents as the main frame; this adds a check > for suitable image mime types and allows them as the main frame. Also > reorders the logic for clarity. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:win7_blink_dbg,linux_precise_blink_rel,mac10.9_blink_dbg,mac10.9_blink_rel,win7_blink_rel,mac10.10_blink_rel,mac10.11_blink_rel,mac10.11_retina_blink_rel,linux_trusty_blink_rel > BUG=584866 > > Committed: https://crrev.com/9fd54d584c2449577e25f761c3ea5ba24a142850 > Cr-Commit-Position: refs/heads/master@{#428193} TBR=lukasza@chromium.org,dimich@chromium.org,eae@chromium.org,dewittj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584866 Committed: https://crrev.com/a613e76691c2aec025c04f54390fe79d3869131e Cr-Commit-Position: refs/heads/master@{#428325}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
phoglund_chromium
Created Revert of Allow image documents in MHT if there is only one resource.
4 years, 1 month ago (2016-10-28 09:51:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460843002/1
4 years, 1 month ago (2016-10-28 09:51:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 09:53:06 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a613e76691c2aec025c04f54390fe79d3869131e Cr-Commit-Position: refs/heads/master@{#428325}
4 years, 1 month ago (2016-10-28 09:54:59 UTC) #7
dewittj
sorry for the trouble, the TestExpectations changes were added by rebaseline-cl and I didn't realize ...
4 years, 1 month ago (2016-10-28 16:16:59 UTC) #8
eae
4 years, 1 month ago (2016-10-30 12:29:41 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698