Chromium Code Reviews
DescriptionRevert of Allow image documents in MHT if there is only one resource. (patchset #3 id:40001 of https://codereview.chromium.org/2425863002/ )
Reason for revert:
This changelist re-enables a bunch of tests that fail (they report Missing): https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/16490
Please write explicitly that you're re-enabling tests in the CL description next time, that would have made sheriffing much easier. The CL description only mentions re-ordering some logic and not that it's also re-enabling tests.
Original issue's description:
> Allow image documents in MHT if there is only one resource.
>
> MHTML could not show image documents as the main frame; this adds a check
> for suitable image mime types and allows them as the main frame. Also
> reorders the logic for clarity.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:win7_blink_dbg,linux_precise_blink_rel,mac10.9_blink_dbg,mac10.9_blink_rel,win7_blink_rel,mac10.10_blink_rel,mac10.11_blink_rel,mac10.11_retina_blink_rel,linux_trusty_blink_rel
> BUG=584866
>
> Committed: https://crrev.com/9fd54d584c2449577e25f761c3ea5ba24a142850
> Cr-Commit-Position: refs/heads/master@{#428193}
TBR=lukasza@chromium.org,dimich@chromium.org,eae@chromium.org,dewittj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584866
Committed: https://crrev.com/a613e76691c2aec025c04f54390fe79d3869131e
Cr-Commit-Position: refs/heads/master@{#428325}
Patch Set 1 #Messages
Total messages: 9 (3 generated)
|