Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2460833002: [debugger] Ensure debug listeners do not throw (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Ensure debug listeners do not throw This exposes a couple of broken tests that used to silently throw within the listener. Mark these as failing for now BUG=v8:5330, v8:5581 Committed: https://crrev.com/16310b2e3933fa2fd5dd94036280eee2e0771ced Cr-Commit-Position: refs/heads/master@{#40672}

Patch Set 1 #

Patch Set 2 : Mark as failing only in debug mode #

Patch Set 3 : Use CHECK to fail in release mode as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M src/d8.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/debug/debug.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
jgruber
We need to use CHECKs so that these tests also fail on release builds without ...
4 years, 1 month ago (2016-10-28 10:02:12 UTC) #10
Yang
On 2016/10/28 10:02:12, jgruber wrote: > We need to use CHECKs so that these tests ...
4 years, 1 month ago (2016-10-31 12:59:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460833002/40001
4 years, 1 month ago (2016-10-31 14:27:48 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-31 14:56:12 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:08 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16310b2e3933fa2fd5dd94036280eee2e0771ced
Cr-Commit-Position: refs/heads/master@{#40672}

Powered by Google App Engine
This is Rietveld 408576698