Decouple Power Monitor from //content.

Decouple Power Monitor from //content.

Move power monitor implmentations from //content into //device/power_monitor
Unittests are also moved from content_unittests target to device_unittests.

BUG=647247
Committed: https://crrev.com/bef9909734ebaa1fd830652cc11c68528fb3d06e
Cr-Commit-Position: refs/heads/master@{#431518}

[leonhsl(Using Gerrit), 2016-10-28 08:51:46]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 08:52:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2016-10-28 09:42:50]

ke.he@intel.com changed reviewers:
+ blundell@chromium.org

[ke.he, 2016-10-28 09:42:51]

blundell@
Could you PTAL at this, Thanks!

[commit-bot: I haz the power, 2016-10-28 10:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 10:10:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2016-10-28 10:14:53]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 10:15:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 10:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 10:45:17]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-10-28 21:33:51]

Looks good, thanks!

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/BUILD.gn
File device/power_monitor/BUILD.gn (right):

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/BUILD....
device/power_monitor/BUILD.gn:7: component("power_monitor_broadcast_source") {
This is the client-side code of power monitor, so it should go in
//device/power_monitor/public/cpp.

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/BUILD....
device/power_monitor/BUILD.gn:26: component("power_monitor_message_broadcaster")
{
this is the implementation of power_monitor, so it should stay here and just be
named (as a target) "power_monitor".

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/power_...
File device/power_monitor/power_monitor_broadcast_source.h (right):

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/power_...
device/power_monitor/power_monitor_broadcast_source.h:25: void
SetClient(device::mojom::PowerMonitor* power_monitor);
I think it would be nicer to just have PowerMonitorBroadcastSource be
initialized with an InterfaceProvider. Then it can do the client setup
completely internally.

[ke.he, 2016-10-29 11:10:53]

blundell@ thanks!
cl updated,  PTAL.

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/BUILD.gn
File device/power_monitor/BUILD.gn (right):

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/BUILD....
device/power_monitor/BUILD.gn:7: component("power_monitor_broadcast_source") {
On 2016/10/28 21:33:51, blundell wrote:
> This is the client-side code of power monitor, so it should go in
> //device/power_monitor/public/cpp.

Done.

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/BUILD....
device/power_monitor/BUILD.gn:26: component("power_monitor_message_broadcaster")
{
On 2016/10/28 21:33:51, blundell wrote:
> this is the implementation of power_monitor, so it should stay here and just
be
> named (as a target) "power_monitor".

Done.

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/power_...
File device/power_monitor/power_monitor_broadcast_source.h (right):

https://codereview.chromium.org/2460823002/diff/1/device/power_monitor/power_...
device/power_monitor/power_monitor_broadcast_source.h:25: void
SetClient(device::mojom::PowerMonitor* power_monitor);
On 2016/10/28 21:33:51, blundell wrote:
> I think it would be nicer to just have PowerMonitorBroadcastSource be
> initialized with an InterfaceProvider. Then it can do the client setup
> completely internally.

Done.

[leonhsl(Using Gerrit), 2016-10-30 11:05:11]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 11:05:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 12:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 12:05:23]

Dry run: This issue passed the CQ dry run.

[ke.he, 2016-11-02 05:41:35]

blundell@  PTAL, thanks:)

[blundell, 2016-11-07 12:50:08]

Apologies, I lost track of this CL and then was OOO for several days :P.

https://codereview.chromium.org/2460823002/diff/40001/content/child/BUILD.gn
File content/child/BUILD.gn (right):

https://codereview.chromium.org/2460823002/diff/40001/content/child/BUILD.gn#...
content/child/BUILD.gn:236:
"//device/power_monitor/public/cpp:power_monitor_broadcast_source",
nit: this target should just be called "cpp".

https://codereview.chromium.org/2460823002/diff/40001/content/child/child_thr...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/2460823002/diff/40001/content/child/child_thr...
content/child/child_thread_impl.cc:514: device::mojom::PowerMonitorPtr
power_monitor_message_broadcaster;
See my comment on power_monitor_broadcast_source.h.

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/po...
File device/power_monitor/power_monitor_message_broadcaster.h (right):

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/po...
device/power_monitor/power_monitor_message_broadcaster.h:26: // Implement
device::mojom::PowerMonitor:
nit: just |device::mojom::PowerMonitor:|

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/po...
device/power_monitor/power_monitor_message_broadcaster.h:30: // Implement
PowerObserver:
same nit.

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/pu...
File device/power_monitor/public/cpp/power_monitor_broadcast_source.h (right):

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/pu...
device/power_monitor/public/cpp/power_monitor_broadcast_source.h:16: // Set
itself as a client of Power Monitor in browser process, Receives state-
nit: Eliminate everything before "Receives". (in decoupling from //content, the
"browser process" comment is now not at the right layer).

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/pu...
device/power_monitor/public/cpp/power_monitor_broadcast_source.h:24:
device::mojom::PowerMonitor* power_monitor);
I was suggesting to initialize this with an InterfaceRegistry* instead so that
the code for obtaining the PowerMonitorPtr could still be internal to this
class.

[ke.he, 2016-11-08 08:59:56]

blundell@, CL updated. PTAL, thanks!

https://codereview.chromium.org/2460823002/diff/40001/content/child/BUILD.gn
File content/child/BUILD.gn (right):

https://codereview.chromium.org/2460823002/diff/40001/content/child/BUILD.gn#...
content/child/BUILD.gn:236:
"//device/power_monitor/public/cpp:power_monitor_broadcast_source",
On 2016/11/07 12:50:08, blundell wrote:
> nit: this target should just be called "cpp".

Done.

https://codereview.chromium.org/2460823002/diff/40001/content/child/child_thr...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/2460823002/diff/40001/content/child/child_thr...
content/child/child_thread_impl.cc:514: device::mojom::PowerMonitorPtr
power_monitor_message_broadcaster;
On 2016/11/07 12:50:08, blundell wrote:
> See my comment on power_monitor_broadcast_source.h.

Done.

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/po...
File device/power_monitor/power_monitor_message_broadcaster.h (right):

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/po...
device/power_monitor/power_monitor_message_broadcaster.h:26: // Implement
device::mojom::PowerMonitor:
On 2016/11/07 12:50:08, blundell wrote:
> nit: just |device::mojom::PowerMonitor:|

Done.

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/po...
device/power_monitor/power_monitor_message_broadcaster.h:30: // Implement
PowerObserver:
On 2016/11/07 12:50:08, blundell wrote:
> same nit.

Done.

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/pu...
File device/power_monitor/public/cpp/power_monitor_broadcast_source.h (right):

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/pu...
device/power_monitor/public/cpp/power_monitor_broadcast_source.h:16: // Set
itself as a client of Power Monitor in browser process, Receives state-
On 2016/11/07 12:50:08, blundell wrote:
> nit: Eliminate everything before "Receives". (in decoupling from //content,
the
> "browser process" comment is now not at the right layer).

Done.

https://codereview.chromium.org/2460823002/diff/40001/device/power_monitor/pu...
device/power_monitor/public/cpp/power_monitor_broadcast_source.h:24:
device::mojom::PowerMonitor* power_monitor);
On 2016/11/07 12:50:08, blundell wrote:
> I was suggesting to initialize this with an InterfaceRegistry* instead so that
> the code for obtaining the PowerMonitorPtr could still be internal to this
> class.

I guess you mean InterfaceProvider here.
Done.

[leonhsl(Using Gerrit), 2016-11-08 09:05:13]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 09:05:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 09:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 09:07:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[leonhsl(Using Gerrit), 2016-11-09 07:28:17]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 07:28:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 08:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 08:24:11]

Dry run: This issue passed the CQ dry run.

[ke.he, 2016-11-09 08:30:13]

code rebase done.

[blundell, 2016-11-09 10:15:25]

lgtm, thanks!

[blundell, 2016-11-09 10:16:40]

Oh, we need OWNERS for //device/power_monitor.

Let's do bajones@chromium.org and myself.

[blundell, 2016-11-09 10:20:53]

blundell@chromium.org changed reviewers:
+ piman@chromium.org, rockot@chromium.org

[blundell, 2016-11-09 10:20:54]

rockot@: Can you review //device?
piman@: Can you review //content as jam@ is OOO and you were on the CL
introducing these classes (https://codereview.chromium.org/17074009)?

Thanks!

[piman, 2016-11-09 16:39:28]

lgtm

[ke.he, 2016-11-10 06:22:38]

blundell@, rockot@, OWNER added. PTAL.
Thanks!

[leonhsl(Using Gerrit), 2016-11-10 06:38:26]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 06:38:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 07:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 07:25:17]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-11-10 08:23:36]

still lgtm, thanks

[Ken Rockot(use gerrit already), 2016-11-10 17:20:40]

lgtm

[ke.he, 2016-11-11 01:45:22]

The CQ bit was checked by ke.he@intel.com

[ke.he, 2016-11-11 01:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2460823002/#ps100001
(title: "Add OWNER in folder device/power_monitor")

[commit-bot: I haz the power, 2016-11-11 01:45:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:50:16]

Failed to apply patch for
content/browser/renderer_host/render_process_host_impl.cc:
While running git apply --index -p1;
  error: patch failed:
content/browser/renderer_host/render_process_host_impl.cc:90
  error: content/browser/renderer_host/render_process_host_impl.cc: patch does
not apply

Patch:       content/browser/renderer_host/render_process_host_impl.cc
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc
b/content/browser/renderer_host/render_process_host_impl.cc
index
ba63945eeb29b13d2d8344f7be2a404fe2520c91..4be07060b0c665ca07d376061b8cdd665684a1a0
100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -90,7 +90,6 @@
 #include "content/browser/notifications/platform_notification_context_impl.h"
 #include "content/browser/permissions/permission_service_context.h"
 #include "content/browser/permissions/permission_service_impl.h"
-#include "content/browser/power_monitor_message_broadcaster.h"
 #include "content/browser/profiler_message_filter.h"
 #include "content/browser/push_messaging/push_messaging_message_filter.h"
 #include "content/browser/quota_dispatcher_host.h"
@@ -162,6 +161,7 @@
 #include "content/public/common/service_names.h"
 #include "content/public/common/url_constants.h"
 #include "device/battery/battery_monitor_impl.h"
+#include "device/power_monitor/power_monitor_message_broadcaster.h"
 #include "device/time_zone_monitor/time_zone_monitor.h"
 #include "gpu/GLES2/gl2extchromium.h"
 #include "gpu/command_buffer/client/gpu_switches.h"
@@ -1251,8 +1251,9 @@ void RenderProcessHostImpl::RegisterMojoInterfaces() {
                  base::Unretained(
                      BrowserMainLoop::GetInstance()->time_zone_monitor())));
 
-  AddUIThreadInterface(registry.get(),
-                       base::Bind(&PowerMonitorMessageBroadcaster::Create));
+  AddUIThreadInterface(
+      registry.get(),
+      base::Bind(&device::PowerMonitorMessageBroadcaster::Create));
 
   scoped_refptr<base::SingleThreadTaskRunner> file_task_runner =
       BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE);

[ke.he, 2016-11-11 01:57:25]

The CQ bit was checked by ke.he@intel.com

[commit-bot: I haz the power, 2016-11-11 01:57:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 02:03:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 02:03:13]

Failed to apply patch for
content/browser/renderer_host/render_process_host_impl.cc:
While running git apply --index -p1;
  error: patch failed:
content/browser/renderer_host/render_process_host_impl.cc:90
  error: content/browser/renderer_host/render_process_host_impl.cc: patch does
not apply

Patch:       content/browser/renderer_host/render_process_host_impl.cc
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc
b/content/browser/renderer_host/render_process_host_impl.cc
index
ba63945eeb29b13d2d8344f7be2a404fe2520c91..4be07060b0c665ca07d376061b8cdd665684a1a0
100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -90,7 +90,6 @@
 #include "content/browser/notifications/platform_notification_context_impl.h"
 #include "content/browser/permissions/permission_service_context.h"
 #include "content/browser/permissions/permission_service_impl.h"
-#include "content/browser/power_monitor_message_broadcaster.h"
 #include "content/browser/profiler_message_filter.h"
 #include "content/browser/push_messaging/push_messaging_message_filter.h"
 #include "content/browser/quota_dispatcher_host.h"
@@ -162,6 +161,7 @@
 #include "content/public/common/service_names.h"
 #include "content/public/common/url_constants.h"
 #include "device/battery/battery_monitor_impl.h"
+#include "device/power_monitor/power_monitor_message_broadcaster.h"
 #include "device/time_zone_monitor/time_zone_monitor.h"
 #include "gpu/GLES2/gl2extchromium.h"
 #include "gpu/command_buffer/client/gpu_switches.h"
@@ -1251,8 +1251,9 @@ void RenderProcessHostImpl::RegisterMojoInterfaces() {
                  base::Unretained(
                      BrowserMainLoop::GetInstance()->time_zone_monitor())));
 
-  AddUIThreadInterface(registry.get(),
-                       base::Bind(&PowerMonitorMessageBroadcaster::Create));
+  AddUIThreadInterface(
+      registry.get(),
+      base::Bind(&device::PowerMonitorMessageBroadcaster::Create));
 
   scoped_refptr<base::SingleThreadTaskRunner> file_task_runner =
       BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE);

[ke.he, 2016-11-11 03:25:36]

The CQ bit was checked by ke.he@intel.com

[commit-bot: I haz the power, 2016-11-11 03:26:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 03:41:46]

Internal error: failed to checkout. Please try again.

[ke.he, 2016-11-11 06:24:44]

The CQ bit was checked by ke.he@intel.com

[ke.he, 2016-11-11 06:24:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
blundell@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2460823002/#ps120001
(title: "code rebase")

[commit-bot: I haz the power, 2016-11-11 06:24:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 07:47:31]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-11 07:55:29]

Description was changed from

==========
Decouple Power Monitor from //content.

Move power monitor implmentations from //content into //device/power_monitor
Unittests are also moved from content_unittests target to device_unittests.

BUG=647247
==========

to

==========
Decouple Power Monitor from //content.

Move power monitor implmentations from //content into //device/power_monitor
Unittests are also moved from content_unittests target to device_unittests.

BUG=647247

Committed: https://crrev.com/bef9909734ebaa1fd830652cc11c68528fb3d06e
Cr-Commit-Position: refs/heads/master@{#431518}
==========

[commit-bot: I haz the power, 2016-11-11 07:55:31]

Patchset 7 (id:??) landed as
https://crrev.com/bef9909734ebaa1fd830652cc11c68528fb3d06e
Cr-Commit-Position: refs/heads/master@{#431518}