third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp - Issue 2460813002: Make slots in non-shadow trees participate in a flat tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp

Issue 2460813002: Make slots in non-shadow trees participate in a flat tree (Closed)

Patch Set: update expectation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp ('k') | third_party/WebKit/Source/core/editing/Position.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp b/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp

index b3056b82b15e7562a0646974a1f878fb91ab17c0..44eb42733ca15b66b601f7ce8fa39096febe717c 100644

--- a/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp

@@ -583,14 +583,17 @@ TEST_F(FlatTreeTraversalTest, v1SlotInDocumentTree) {

setupDocumentTree(mainHTML);

Element* body = document().body();

Element* parent = body->querySelector("#parent");

+ Element* slot = body->querySelector("slot");

Element* child1 = body->querySelector("#child1");

Element* child2 = body->querySelector("#child2");

- EXPECT_EQ(child1, FlatTreeTraversal::firstChild(*parent));

+ EXPECT_EQ(slot, FlatTreeTraversal::firstChild(*parent));

+ EXPECT_EQ(child1, FlatTreeTraversal::firstChild(*slot));

EXPECT_EQ(child2, FlatTreeTraversal::nextSibling(*child1));

EXPECT_EQ(nullptr, FlatTreeTraversal::nextSibling(*child2));

- EXPECT_EQ(parent, FlatTreeTraversal::parent(*child1));

- EXPECT_EQ(parent, FlatTreeTraversal::parent(*child2));

+ EXPECT_EQ(slot, FlatTreeTraversal::parent(*child1));

+ EXPECT_EQ(slot, FlatTreeTraversal::parent(*child2));

+ EXPECT_EQ(parent, FlatTreeTraversal::parent(*slot));

}

} // namespace blink