third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp - Issue 2460813002: Make slots in non-shadow trees participate in a flat tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

Issue 2460813002: Make slots in non-shadow trees participate in a flat tree (Closed)

Patch Set: update expectation Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

index e0d9f0b90543fa91ffc6413bf7479015ec59d4ea..77046c3b2ad24a774e8c5737e3b599527bf9ec82 100644

--- a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

@@ -48,7 +48,7 @@ namespace blink {

LayoutTreeBuilderForElement::LayoutTreeBuilderForElement(Element& element,

ComputedStyle* style)

: LayoutTreeBuilder(element, nullptr), m_style(style) {

- DCHECK(!element.isSlotOrActiveInsertionPoint());

+ DCHECK(!element.isActiveSlotOrActiveInsertionPoint());

if (element.isFirstLetterPseudoElement()) {

if (LayoutObject* nextLayoutObject =

FirstLetterPseudoElement::firstLetterTextLayoutObject(element))