third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp - Issue 2460813002: Make slots in non-shadow trees participate in a flat tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp

Issue 2460813002: Make slots in non-shadow trees participate in a flat tree (Closed)

Patch Set: update expectation Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/crashes/slots-nested-in-document-tree-crash.html ('k') | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp b/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp

index 30f99787c2fac3b111b701af42ad7c9986046af2..f8943953cec6c78057a61055cbc0390ae129844d 100644

--- a/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp

@@ -46,7 +46,7 @@ ElementResolveContext::ElementResolveContext(Element& element)

m_distributedToInsertionPoint(false) {

LayoutTreeBuilderTraversal::ParentDetails parentDetails;

m_parentNode =

- element.isSlotOrActiveInsertionPoint()

+ element.isActiveSlotOrActiveInsertionPoint()

? nullptr

: LayoutTreeBuilderTraversal::parent(element, &parentDetails);

m_distributedToInsertionPoint = parentDetails.insertionPoint();