Issue 246080: Prevents a duplicate beforeunload dialog after window.close()....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246080: Prevents a duplicate beforeunload dialog after window.close().... (Closed)

Created:
11 years, 2 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prevents a duplicate beforeunload dialog after window.close(). If the renderer tells the browser to close a window, we no longer run the unload events, because the renderer already has. BUG=11647 TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	chrome/browser/browser_browsertest.cc	View		2 chunks	+23 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages