Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 246079: More WebView / WebViewDelegate cleanup. (Closed)

Created:
11 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

More WebView / WebViewDelegate cleanup. Moves a bunch of methods from glue to the WebKit API. R=dglazkov BUG=10033 TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -142 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 1 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 7 chunks +49 lines, -43 lines 0 comments Download
M webkit/api/public/WebFrameClient.h View 1 2 chunks +17 lines, -2 lines 0 comments Download
M webkit/api/public/WebView.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/api/public/WebViewClient.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M webkit/glue/editor_client_impl.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M webkit/glue/empty_webframeclient.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/inspector_client_impl.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 1 1 chunk +7 lines, -11 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webview.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 2 chunks +0 lines, -21 lines 0 comments Download
M webkit/glue/webview_impl.h View 1 4 chunks +4 lines, -9 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 chunks +8 lines, -16 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 2 months ago (2009-10-02 22:13:54 UTC) #1
dglazkov
11 years, 2 months ago (2009-10-03 00:04:08 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698