Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2460773003: [wasm] make WebAssembly.Instance require a WebAssembly.Memory (Closed)

Created:
4 years, 1 month ago by Eric Holk
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] make WebAssembly.Instance require a WebAssembly.Memory BUG= Committed: https://crrev.com/96d12ac6dd6ba4075383fa7085a9810e11821a99 Cr-Commit-Position: refs/heads/master@{#40654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-serialization.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 3 chunks +14 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Eric Holk
4 years, 1 month ago (2016-10-28 17:46:56 UTC) #2
titzer
On 2016/10/28 17:46:56, Eric Holk wrote: lgtm
4 years, 1 month ago (2016-10-28 17:48:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460773003/1
4 years, 1 month ago (2016-10-28 17:49:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 18:13:07 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96d12ac6dd6ba4075383fa7085a9810e11821a99
Cr-Commit-Position: refs/heads/master@{#40654}

Powered by Google App Engine
This is Rietveld 408576698