Refreshes the caret bounds on window move for IME UI.

Refreshes the caret bounds on window move for IME UI.

BUG=365822
R=oshima@chromium.org, ben@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266397

[oshima, 2014-04-23 05:55:44]

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc#ne...
ui/views/widget/widget.cc:1101: 
You may also want to update when the size is changed, which may cause the
re-layout?

[Jun Mukai, 2014-04-23 22:23:04]

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc#ne...
ui/views/widget/widget.cc:1101: 
On 2014/04/23 05:55:44, oshima wrote:
> You may also want to update when the size is changed, which may cause the
> re-layout?

I don't think so, each view can update the boundary upon its re-layout. For
example, views::Textfield does this at OnBoundsChanged()

[oshima, 2014-04-23 22:54:15]

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc#ne...
ui/views/widget/widget.cc:1101: 
On 2014/04/23 22:23:04, Jun Mukai wrote:
> On 2014/04/23 05:55:44, oshima wrote:
> > You may also want to update when the size is changed, which may cause the
> > re-layout?
> 
> I don't think so, each view can update the boundary upon its re-layout. For
> example, views::Textfield does this at OnBoundsChanged()

Are you sure it gets called when only parent bounds has changed?

[Jun Mukai, 2014-04-23 23:16:02]

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc#ne...
ui/views/widget/widget.cc:1101: 
On 2014/04/23 22:54:15, oshima wrote:
> On 2014/04/23 22:23:04, Jun Mukai wrote:
> > On 2014/04/23 05:55:44, oshima wrote:
> > > You may also want to update when the size is changed, which may cause the
> > > re-layout?
> > 
> > I don't think so, each view can update the boundary upon its re-layout. For
> > example, views::Textfield does this at OnBoundsChanged()
> 
> Are you sure it gets called when only parent bounds has changed?

Sorry, I got unsure about your point.
The widget size change causes RootView::SetSize (see above), and it causes root
view's bounds change (and Layout). Whether this causes
Textfield::OnBoundsChanged or not depends on how the views are structured.
However, if the widget's size change causes the change of the bounds of
textfield (or whatever) in the widget, OnBoundsChanged() has to be called.

[Jun Mukai, 2014-04-23 23:26:47]

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/246073009/diff/1/ui/views/widget/widget.cc#ne...
ui/views/widget/widget.cc:1101: 
On 2014/04/23 23:16:02, Jun Mukai wrote:
> On 2014/04/23 22:54:15, oshima wrote:
> > On 2014/04/23 22:23:04, Jun Mukai wrote:
> > > On 2014/04/23 05:55:44, oshima wrote:
> > > > You may also want to update when the size is changed, which may cause
the
> > > > re-layout?
> > > 
> > > I don't think so, each view can update the boundary upon its re-layout.
For
> > > example, views::Textfield does this at OnBoundsChanged()
> > 
> > Are you sure it gets called when only parent bounds has changed?
> 
> Sorry, I got unsure about your point.
> The widget size change causes RootView::SetSize (see above), and it causes
root
> view's bounds change (and Layout). Whether this causes
> Textfield::OnBoundsChanged or not depends on how the views are structured.
> However, if the widget's size change causes the change of the bounds of
> textfield (or whatever) in the widget, OnBoundsChanged() has to be called.

chatted offline and I was wrong.
There could be a case that resize just moves a container parent which contains a
textfield. In that case, the container's bounds will be changed but this keeps
textfield in it.
Added.

[oshima, 2014-04-23 23:32:51]

lgtm

[Jun Mukai, 2014-04-23 23:34:01]

ben, could you take a look?

[Ben Goodger (Google), 2014-04-24 15:51:57]

lgtm

[Jun Mukai, 2014-04-24 17:49:18]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-24 21:54:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/246073009/20001

[commit-bot: I haz the power, 2014-04-24 22:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:39:56]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Jun Mukai, 2014-04-24 22:40:31]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:42:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/246073009/20001

[commit-bot: I haz the power, 2014-04-24 23:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:53:04]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Jun Mukai, 2014-04-25 00:04:56]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:05:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/246073009/20001

[commit-bot: I haz the power, 2014-04-25 00:11:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:11:46]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Jun Mukai, 2014-04-25 18:25:01]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-25 21:46:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/246073009/20001

[commit-bot: I haz the power, 2014-04-25 23:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:39:35]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel
  tryserver.chromium on linux_chromium_rel

[Jun Mukai, 2014-04-26 00:06:16]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:08:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/246073009/40001

[commit-bot: I haz the power, 2014-04-26 03:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:53:52]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Jun Mukai, 2014-04-26 03:54:57]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:56:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/246073009/40001

[commit-bot: I haz the power, 2014-04-27 00:17:40]

Change committed as 266397