Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2460723005: Merged: Don't call FastNewFunctionContextStub if context is bigger than kMaxRegularHeapObjectSize. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 __ Push(info->scope()->GetScopeInfo(info->isolate())); 187 __ Push(info->scope()->GetScopeInfo(info->isolate()));
188 __ CallRuntime(Runtime::kNewScriptContext); 188 __ CallRuntime(Runtime::kNewScriptContext);
189 PrepareForBailoutForId(BailoutId::ScriptContext(), 189 PrepareForBailoutForId(BailoutId::ScriptContext(),
190 BailoutState::TOS_REGISTER); 190 BailoutState::TOS_REGISTER);
191 // The new target value is not used, clobbering is safe. 191 // The new target value is not used, clobbering is safe.
192 DCHECK_NULL(info->scope()->new_target_var()); 192 DCHECK_NULL(info->scope()->new_target_var());
193 } else { 193 } else {
194 if (info->scope()->new_target_var() != nullptr) { 194 if (info->scope()->new_target_var() != nullptr) {
195 __ push(a3); // Preserve new target. 195 __ push(a3); // Preserve new target.
196 } 196 }
197 FastNewFunctionContextStub stub(isolate()); 197 if (slots <= FastNewFunctionContextStub::kMaximumSlots) {
198 __ li(FastNewFunctionContextDescriptor::SlotsRegister(), Operand(slots)); 198 FastNewFunctionContextStub stub(isolate());
199 __ CallStub(&stub); 199 __ li(FastNewFunctionContextDescriptor::SlotsRegister(),
200 // Result of FastNewFunctionContextStub is always in new space. 200 Operand(slots));
201 need_write_barrier = false; 201 __ CallStub(&stub);
202 // Result of FastNewFunctionContextStub is always in new space.
203 need_write_barrier = false;
204 } else {
205 __ push(a1);
206 __ CallRuntime(Runtime::kNewFunctionContext);
207 }
202 if (info->scope()->new_target_var() != nullptr) { 208 if (info->scope()->new_target_var() != nullptr) {
203 __ pop(a3); // Restore new target. 209 __ pop(a3); // Restore new target.
204 } 210 }
205 } 211 }
206 function_in_register_a1 = false; 212 function_in_register_a1 = false;
207 // Context is returned in v0. It replaces the context passed to us. 213 // Context is returned in v0. It replaces the context passed to us.
208 // It's saved in the stack and kept live in cp. 214 // It's saved in the stack and kept live in cp.
209 __ mov(cp, v0); 215 __ mov(cp, v0);
210 __ sw(v0, MemOperand(fp, StandardFrameConstants::kContextOffset)); 216 __ sw(v0, MemOperand(fp, StandardFrameConstants::kContextOffset));
211 // Copy any necessary parameters into the context. 217 // Copy any necessary parameters into the context.
(...skipping 3545 matching lines...) Expand 10 before | Expand all | Expand 10 after
3757 reinterpret_cast<uint32_t>( 3763 reinterpret_cast<uint32_t>(
3758 isolate->builtins()->OnStackReplacement()->entry())); 3764 isolate->builtins()->OnStackReplacement()->entry()));
3759 return ON_STACK_REPLACEMENT; 3765 return ON_STACK_REPLACEMENT;
3760 } 3766 }
3761 3767
3762 3768
3763 } // namespace internal 3769 } // namespace internal
3764 } // namespace v8 3770 } // namespace v8
3765 3771
3766 #endif // V8_TARGET_ARCH_MIPS 3772 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698