Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2460713002: Add @MainDex to MediaCodecUtil. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
4 years, 1 month ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add @MainDex to MediaCodecUtil. MediaCodecUtil is used in non-browser processes, so it should be kept in the main dex file. This keeps the previously annotated inner classes in the main dex file as well. BUG=657024 Committed: https://crrev.com/96ce916013bb343950629bef619ae67aed4f1fb9 Cr-Commit-Position: refs/heads/master@{#428219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecUtil.java View 4 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
estevenson
ptal watk!
4 years, 1 month ago (2016-10-27 22:14:20 UTC) #2
watk
lgtm
4 years, 1 month ago (2016-10-27 22:16:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460713002/1
4 years, 1 month ago (2016-10-27 22:18:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 23:41:25 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:47:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96ce916013bb343950629bef619ae67aed4f1fb9
Cr-Commit-Position: refs/heads/master@{#428219}

Powered by Google App Engine
This is Rietveld 408576698