Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2460703005: [Sync] IWYU cleanup. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] IWYU cleanup. BUG= Committed: https://crrev.com/ef2d347246bfc3cb768a92a5000883379bd51b88 Cr-Commit-Position: refs/heads/master@{#428559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/chrome_sync_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/migration_waiter.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/multi_client_status_change_checker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_integration_test_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/model_type_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/model_type_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/attachments/on_disk_attachment_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_connection_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server_entity.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_bookmark_entity.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/test_entry_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
skym
PTAL, this is just the result of running the command below. tools/remove_duplicate_includes.py components/sync/ components/sync_bookmarks/ components/sync_sessions/ ...
4 years, 1 month ago (2016-10-28 23:00:54 UTC) #4
maxbogue
lgtm
4 years, 1 month ago (2016-10-28 23:34:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460703005/1
4 years, 1 month ago (2016-10-28 23:35:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-29 00:35:31 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ef2d347246bfc3cb768a92a5000883379bd51b88 Cr-Commit-Position: refs/heads/master@{#428559}
4 years, 1 month ago (2016-10-29 00:44:43 UTC) #12
phoglund_chromium
4 years, 1 month ago (2016-10-31 10:27:25 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2466463002/ by phoglund@chromium.org.

The reason for reverting is: Likely made sync tests flaky. See
https://bugs.chromium.org/p/chromium/issues/detail?id=660655 for more details.

BUG=660655.

Powered by Google App Engine
This is Rietveld 408576698