Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2460683002: Fix focus ring damage sometimes being 1 pixel off. (Closed)

Created:
4 years, 1 month ago by Bret
Modified:
4 years, 1 month ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix focus ring damage sometimes being 1 pixel off. crrev.com/2386033002 changed the focus ring stroke from being 1 pixel to being scaled based on the zoom level, which changed the type to a float. When calculating the outdent (and thus damage) the width value lost precsion and so at certain fractional zoom levels would leave a 1 pixel line behind. This patch ceils the width value instead, to make sure that pixel is redrawn when necessary. R=bokan@chromium.org BUG=658648 Committed: https://crrev.com/b18b97a7da62e85fc08eddaefbc95b49c4d7b648 Cr-Commit-Position: refs/heads/master@{#429153}

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : fix assert on osx #

Patch Set 4 : fix linux component/debug link error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleTest.cpp View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleBackgroundData.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Bret
4 years, 1 month ago (2016-10-27 21:39:10 UTC) #1
bokan
change looks fine, could we get a test?
4 years, 1 month ago (2016-10-27 21:40:42 UTC) #2
Bret
On 2016/10/27 21:40:42, bokan wrote: > change looks fine, could we get a test? Added ...
4 years, 1 month ago (2016-10-28 01:01:11 UTC) #3
bokan
thank you, lgtm
4 years, 1 month ago (2016-10-28 12:59:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460683002/40001
4 years, 1 month ago (2016-10-28 17:58:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/154710)
4 years, 1 month ago (2016-10-28 18:35:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460683002/60001
4 years, 1 month ago (2016-11-01 21:00:41 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-01 23:33:49 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 23:35:50 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b18b97a7da62e85fc08eddaefbc95b49c4d7b648
Cr-Commit-Position: refs/heads/master@{#429153}

Powered by Google App Engine
This is Rietveld 408576698