Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2460663002: Moves OSExchangeDataProviderMus to aura/mus (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
eroman, Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul, dcheng, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves OSExchangeDataProviderMus to aura/mus I'm going to need it within ui/aura/mus, so moving there. BUG=659155 TEST=covered by tests R=erg@chromium.org,eroman@chromium.org Committed: https://crrev.com/8f993309b287cb08554580ba662f215a33f6cb41 Cr-Commit-Position: refs/heads/master@{#428204}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : fix arm compile #

Patch Set 4 : DEPS and daisy compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -761 lines) Patch
M ui/aura/BUILD.gn View 4 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/aura/mus/os_exchange_data_provider_mus.h View 1 5 chunks +13 lines, -14 lines 0 comments Download
A + ui/aura/mus/os_exchange_data_provider_mus.cc View 1 10 chunks +17 lines, -24 lines 0 comments Download
A + ui/aura/mus/os_exchange_data_provider_mus_unittest.cc View 1 7 chunks +12 lines, -12 lines 0 comments Download
M ui/views/mus/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/mus/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/drag_drop_client_mus.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/mus/drop_target_mus.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D ui/views/mus/os_exchange_data_provider_mus.h View 1 chunk +0 lines, -118 lines 0 comments Download
D ui/views/mus/os_exchange_data_provider_mus.cc View 1 chunk +0 lines, -372 lines 0 comments Download
D ui/views/mus/os_exchange_data_provider_mus_unittest.cc View 1 chunk +0 lines, -211 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
sky
eroman: ui/aura/DEPS change. ui/aura already indirectly depends upon net. erg: the rest. I ran git ...
4 years, 1 month ago (2016-10-27 20:44:42 UTC) #3
Elliot Glaysher
lgtm
4 years, 1 month ago (2016-10-27 20:54:57 UTC) #4
eroman
Can you remove net from the include rules in "ui/views/mus/DEPS", since the only consumers of ...
4 years, 1 month ago (2016-10-27 21:05:07 UTC) #9
sky
On 2016/10/27 21:05:07, eroman wrote: > Can you remove net from the include rules in ...
4 years, 1 month ago (2016-10-27 21:16:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460663002/60001
4 years, 1 month ago (2016-10-27 21:17:29 UTC) #13
eroman
lgtm
4 years, 1 month ago (2016-10-27 21:45:25 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-27 23:24:22 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:29:18 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8f993309b287cb08554580ba662f215a33f6cb41
Cr-Commit-Position: refs/heads/master@{#428204}

Powered by Google App Engine
This is Rietveld 408576698