Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 246063008: Update WebRtc/libjingle revision from r5831 to r5963. (Closed)

Created:
6 years, 8 months ago by perkj_chrome
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update WebRtc/libjingle revision from r5831 to r5963. This also temporaryly disable all WebRtcBrowserTest on Android. TBR Ronghua for README file change. R=henrika@chromium.org, phoglund@chromium.org TBR=ronghuawu BUG=362852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265605

Patch Set 1 #

Patch Set 2 : Updated libjingle README. #

Patch Set 3 : Disabled WebRtcBrowserTests on Android #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 2 1 chunk +3 lines, -0 lines 2 comments Download
M third_party/libjingle/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
perkj_chrome
Can you please review?
6 years, 8 months ago (2014-04-23 07:43:32 UTC) #1
henrika (OOO until Aug 14)
LGTM
6 years, 8 months ago (2014-04-23 07:52:05 UTC) #2
phoglund_chromium
https://codereview.chromium.org/246063008/diff/40001/build/android/pylib/gtest/filter/content_browsertests_disabled File build/android/pylib/gtest/filter/content_browsertests_disabled (right): https://codereview.chromium.org/246063008/diff/40001/build/android/pylib/gtest/filter/content_browsertests_disabled#newcode125 build/android/pylib/gtest/filter/content_browsertests_disabled:125: WebRtcBrowserTests/WebRtcBrowserTest.* I think what you want here is WebRtcBrowserTest.*. ...
6 years, 8 months ago (2014-04-23 09:57:12 UTC) #3
phoglund_chromium
lgtm https://codereview.chromium.org/246063008/diff/40001/build/android/pylib/gtest/filter/content_browsertests_disabled File build/android/pylib/gtest/filter/content_browsertests_disabled (right): https://codereview.chromium.org/246063008/diff/40001/build/android/pylib/gtest/filter/content_browsertests_disabled#newcode125 build/android/pylib/gtest/filter/content_browsertests_disabled:125: WebRtcBrowserTests/WebRtcBrowserTest.* On 2014/04/23 09:57:12, phoglund wrote: > I ...
6 years, 8 months ago (2014-04-23 10:11:14 UTC) #4
perkj_chrome
6 years, 8 months ago (2014-04-23 10:40:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r265605 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698