Issue 246060: Revert 27705 - Move various methods from glue/webview.h to api/public/WebView...

Issue 246060: Revert 27705 - Move various methods from glue/webview.h to api/public/WebView... (Closed)

Created:
11 years, 2 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert 27705 - Move various methods from glue/webview.h to api/public/WebView.h ** browser_tests started failing at this revision. See: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio ** I'll reorder the methods in webview_impl.cc in a followup CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 TBR=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27711

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+155 lines, -95 lines)			Patch
M	chrome/renderer/print_web_view_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	7 chunks	+14 lines, -9 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/api/public/WebView.h	View	4 chunks	+1 line, -35 lines	0 comments	Download
M	webkit/glue/chrome_client_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/mimetype_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webview.h	View	3 chunks	+52 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View	3 chunks	+21 lines, -10 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	9 chunks	+38 lines, -14 lines	0 comments	Download
M	webkit/glue/webview_unittest.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	webkit/glue/webworker_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/mac/test_shell_webview.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/mac/webview_host.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/webview_host_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/webview_host_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages