Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2460563002: [Bindings] Reformat methods.cpp.tmpl (2/4) (Closed)

Created:
4 years, 1 month ago by peria
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (this CL) - Attributes (https://codereview.chromium.org/2449043007/) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 Committed: https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f Cr-Commit-Position: refs/heads/master@{#428332}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6926 lines, -7860 lines) Patch
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 13 chunks +329 lines, -341 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp View 1 chunk +100 lines, -116 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 1 chunk +15 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 1 chunk +15 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 1 chunk +15 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 3 chunks +556 lines, -673 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +222 lines, -251 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 chunk +86 lines, -100 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 chunk +113 lines, -131 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 2 chunks +173 lines, -178 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 chunk +83 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 chunk +15 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +21 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 chunk +27 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 chunk +16 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 chunk +161 lines, -182 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +69 lines, -70 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +25 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +59 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp View 1 chunk +50 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp View 2 chunks +31 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +4145 lines, -4710 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +15 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +124 lines, -141 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp View 1 chunk +26 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +223 lines, -267 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +185 lines, -206 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
peria
PTL
4 years, 1 month ago (2016-10-27 20:22:49 UTC) #5
haraken
LGTM
4 years, 1 month ago (2016-10-27 20:30:25 UTC) #6
bashi
lgtm
4 years, 1 month ago (2016-10-27 23:49:09 UTC) #7
Yuki
lgtm
4 years, 1 month ago (2016-10-28 09:26:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460563002/20001
4 years, 1 month ago (2016-10-28 09:55:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460563002/20001
4 years, 1 month ago (2016-10-28 09:56:53 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 11:12:01 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 11:14:22 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b912a1b09ed861cb2988c865355825f852dd300f
Cr-Commit-Position: refs/heads/master@{#428332}

Powered by Google App Engine
This is Rietveld 408576698