Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2209)

Unified Diff: content/shell/BUILD.gn

Issue 2460503002: content_shell: Add runtime resources into data_deps. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index 3fc427df7421e7b642fcf313eec083229abbedca..560cdcbc5686b2f4dac13de9d49266c958ded9b9 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -398,7 +398,7 @@ group("resources") {
public_deps = [
":copy_shell_resources",
]
- deps = [
+ data_deps = [
"//components/test_runner:resources",
]
}
@@ -501,11 +501,14 @@ if (is_android) {
deps = [
":content_shell_lib",
- ":pak",
"//build/config/sanitizers:deps",
"//build/win:default_exe_manifest",
]
+ data_deps = [
Dirk Pranke 2016/10/28 00:25:56 Are you sure this isn't also needed as a regular d
mithro 2016/10/31 01:46:47 Does anything need the :pak at compile / linking t
+ ":pak",
+ ]
+
if (is_win) {
deps += [ "//sandbox" ]
« no previous file with comments | « components/test_runner/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698