Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2460493002: WebRTC: Add new Linux (more configs) bots. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Add new Linux (more configs) bots. This new bot runs GN with a minimal amount of configurations set, then compiles. This will give us coverage for the cases where dcheck_always_on=false and rtc_use_h264=false. It also re-runs GN+compile with: * rtc_enable_intelligibility_enhancer=true * rtc_enable_protobuf=false * rtc_include_opus=false If we want to test more configurations like this, we can just add them to this bot in the future. BUG=652197, 611054 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98

Patch Set 1 : . #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -215 lines) Patch
M masters/master.client.webrtc/master_linux_cfg.py View 2 chunks +6 lines, -0 lines 0 comments Download
M masters/master.client.webrtc/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.tryserver.webrtc/master.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M masters/master.tryserver.webrtc/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/chromium_config.py View 1 chunk +4 lines, -3 lines 0 comments Download
A scripts/slave/recipes/webrtc/more_configs.py View 1 chunk +77 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json View 1 10 chunks +190 lines, -110 lines 0 comments Download
A + scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json View 1 11 chunks +196 lines, -102 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
kjellander_chromium
This bot should be useful!
4 years, 1 month ago (2016-10-27 09:09:55 UTC) #6
ehmaldonado_chromium
On 2016/10/27 09:09:55, kjellander_chromium wrote: > This bot should be useful! LGTM :)
4 years, 1 month ago (2016-10-27 09:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460493002/40001
4 years, 1 month ago (2016-10-27 09:39:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/321e54f2ed70da10)
4 years, 1 month ago (2016-10-27 09:44:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460493002/60001
4 years, 1 month ago (2016-10-27 09:52:39 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 10:02:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/b061208b3f8e9f45d4c4...

Powered by Google App Engine
This is Rietveld 408576698