cc: Remove more references to owning_layer_ from RenderSurfaceImpl

cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b
Cr-Commit-Position: refs/heads/master@{#428991}

[ajuma, 2016-10-31 21:32:54]

Description was changed from

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
==========

to

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ajuma, 2016-10-31 21:47:14]

Description was changed from

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ajuma, 2016-10-31 21:47:15]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[ajuma, 2016-10-31 21:47:23]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 21:48:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 22:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:50:53]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2016-10-31 23:12:00]

lgtm

https://codereview.chromium.org/2460413003/diff/1/cc/layers/render_surface_im...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/2460413003/diff/1/cc/layers/render_surface_im...
cc/layers/render_surface_impl.cc:37: stable_effect_node_id_(owning_layer->id()),
nit : The node in 'stable_effect_node_id' is confusing to me. I would expect it
to be directly referring to a node in effect tree (but, its not). So, I would
prefer the name 'stable_effect_id' for this.

[ajuma, 2016-10-31 23:23:39]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:24:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-10-31 23:26:00]

https://codereview.chromium.org/2460413003/diff/1/cc/layers/render_surface_im...
File cc/layers/render_surface_impl.cc (right):

https://codereview.chromium.org/2460413003/diff/1/cc/layers/render_surface_im...
cc/layers/render_surface_impl.cc:37: stable_effect_node_id_(owning_layer->id()),
On 2016/10/31 23:12:00, jaydasika wrote:
> nit : The node in 'stable_effect_node_id' is confusing to me. I would expect
it
> to be directly referring to a node in effect tree (but, its not). So, I would
> prefer the name 'stable_effect_id' for this. 

Done.

[commit-bot: I haz the power, 2016-11-01 00:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:37:59]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-11-01 13:28:13]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-11-01 13:28:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org
Link to the patchset: https://codereview.chromium.org/2460413003/#ps20001
(title: "Address review comment")

[commit-bot: I haz the power, 2016-11-01 13:28:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 13:33:32]

Description was changed from

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-11-01 13:33:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 13:37:59]

Description was changed from

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove more references to owning_layer_ from RenderSurfaceImpl

This removes more dependencies of RenderSurfaceImpl on its owning layer.
Specifically, this removes the use of owning_layer_ for accessing
property trees and debug colors, and for gettng the surface's
effect tree index. This also renames the OwningLayerId() method to id().

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b
Cr-Commit-Position: refs/heads/master@{#428991}
==========

[commit-bot: I haz the power, 2016-11-01 13:38:00]

Patchset 2 (id:??) landed as
https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b
Cr-Commit-Position: refs/heads/master@{#428991}

[ajuma, 2016-11-07 21:46:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2483033002/ by ajuma@chromium.org.

The reason for reverting is: Possibly caused a regression in draw properties
computation time (see http://crbug.com/663068)..