Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2460403002: [modules] Add namespace import snippet to test-bytecode-generator. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Add namespace import snippet to test-bytecode-generator. R=rmcilroy@chromium.org BUG=v8:1569 Committed: https://crrev.com/24b1c1abfc1b397b4fff8b91e0a4e750e7e55217 Cr-Commit-Position: refs/heads/master@{#40694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 1 chunk +82 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 1 month ago (2016-10-31 13:57:48 UTC) #1
rmcilroy
Awesome, thanks. LGTM.
4 years, 1 month ago (2016-11-01 12:56:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460403002/1
4 years, 1 month ago (2016-11-02 09:07:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 09:30:33 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24b1c1abfc1b397b4fff8b91e0a4e750e7e55217
Cr-Commit-Position: refs/heads/master@{#40694}

Powered by Google App Engine
This is Rietveld 408576698