Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2460323002: Avoid nullptr deref when requesting http auth for non-webcontents requests (Closed)

Created:
4 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
Reviewers:
danno
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, vabr+watchlistlogin_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid nullptr deref when requesting http auth for non-webcontents requests BUG=660776 Committed: https://crrev.com/a1a345d3d77742531fb89e5a9c5aaf85d2a9c5d5 Cr-Commit-Position: refs/heads/master@{#428683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/ui/login/login_handler.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
danno
lgtm
4 years, 1 month ago (2016-10-31 10:04:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460323002/1
4 years, 1 month ago (2016-10-31 10:05:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 10:59:07 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 11:01:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1a345d3d77742531fb89e5a9c5aaf85d2a9c5d5
Cr-Commit-Position: refs/heads/master@{#428683}

Powered by Google App Engine
This is Rietveld 408576698