content/renderer/render_frame_impl.cc - Issue 2460303003: Checking RendererThreadImpl for null when creating media player.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2460303003: Checking RendererThreadImpl for null when creating media player. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index ddaef125f6d1b58a2f9c2635457a48678d8d7bca..afda74e7a6b2bc96e737973ae2e31b14fe1b9aa7 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -2735,6 +2735,9 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(

blink::WebURL url = source.getAsURL();

RenderThreadImpl* render_thread = RenderThreadImpl::current();

+ // Render thread may not exist in tests:

Avi (use Gerrit) 2016/10/31 14:45:29 Make comments be complete sentences, ending in a .

o1ka 2016/10/31 14:58:38 Done.

+ if (!render_thread)

+ return nullptr;

scoped_refptr<media::SwitchableAudioRendererSink> audio_renderer_sink =

AudioDeviceFactory::NewSwitchableAudioRendererSink(