Checking RendererThreadImpl for null when creating media player.

content/renderer/media/audio_device_factory.cc

Index: content/renderer/media/audio_device_factory.cc
diff --git a/content/renderer/media/audio_device_factory.cc b/content/renderer/media/audio_device_factory.cc
index 2b06de485ee6941b49996526b7766cc5ec3813b3..ba526043ecbf26a3afb2aa15b6d315ca9112175f 100644
--- a/content/renderer/media/audio_device_factory.cc
+++ b/content/renderer/media/audio_device_factory.cc
@@ -72,6 +72,8 @@ scoped_refptr<media::SwitchableAudioRendererSink> NewMixableSink(
     const std::string& device_id,
     const url::Origin& security_origin) {
   RenderThreadImpl* render_thread = RenderThreadImpl::current();
+  CHECK(render_thread) << "RenderThreadImpl is not instantiated, or "
+                       << "GetOutputDeviceInfo() is called on a wrong thread ";
   return scoped_refptr<media::AudioRendererMixerInput>(
       render_thread->GetAudioRendererMixerManager()->CreateInput(
           render_frame_id, session_id, device_id, security_origin,
@@ -185,8 +187,8 @@ media::OutputDeviceInfo AudioDeviceFactory::GetOutputDeviceInfo(
     const std::string& device_id,
     const url::Origin& security_origin) {
   RenderThreadImpl* render_thread = RenderThreadImpl::current();
-  DCHECK(render_thread) << "RenderThreadImpl is not instantiated, or "
-                        << "GetOutputDeviceInfo() is called on a wrong thread ";
+  CHECK(render_thread) << "RenderThreadImpl is not instantiated, or "
+                       << "GetOutputDeviceInfo() is called on a wrong thread ";

[Avi (use Gerrit), 2016/10/31 14:45:29]

Why a CHECK here and above and not a DCHECK? 

[o1ka, 2016/10/31 14:58:38]

Done.

   return render_thread->GetAudioRendererMixerManager()->GetOutputDeviceInfo(
       render_frame_id, session_id, device_id, security_origin);
 }