Issue 246029: Linux: Raise window after click on titlebar or border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246029: Linux: Raise window after click on titlebar or border. (Closed)

Created:
11 years, 2 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: Raise window after click on titlebar or border. BUG=23318 TEST=checked that it matches native window behavior in metacity and kwin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27531

Patch Set 1 #

Patch Set 2 : only raise after click on titlebar or border #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/gtk/browser_window_gtk.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. If the window is already on top, what does gdk_window_raise do?

11 years, 2 months ago (2009-09-29 17:55:16 UTC) #2

use derat at chromium.org

11 years, 2 months ago (2009-09-29 20:16:32 UTC) #3

gdk_window_x11_raise() just calls XRaiseWindow(), so it's fine to call
again for a window that's already on top.

On Tue, Sep 29, 2009 at 10:55 AM,  <tony@chromium.org> wrote:
> LGTM.
>
> If the window is already on top, what does gdk_window_raise do?
>
> http://codereview.chromium.org/246029
>

Expand Messages | Collapse Messages