Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Unified Diff: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

Issue 2460253002: Update WebAPKs even if the WebAPK start URL has no Web Manifest part 2/3 (Closed)
Patch Set: Merge branch 'master' into update_fail_refactor0 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
diff --git a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
deleted file mode 100644
index 5d3849ec69787a1ce1718546b510ed5cee415e6c..0000000000000000000000000000000000000000
--- a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
+++ /dev/null
@@ -1,95 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_ANDROID_WEBAPK_MANIFEST_UPGRADE_DETECTOR_FETCHER_H_
-#define CHROME_BROWSER_ANDROID_WEBAPK_MANIFEST_UPGRADE_DETECTOR_FETCHER_H_
-
-#include "base/android/jni_android.h"
-#include "base/android/jni_weak_ref.h"
-#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
-#include "chrome/browser/android/shortcut_info.h"
-#include "content/public/browser/web_contents_observer.h"
-#include "third_party/skia/include/core/SkBitmap.h"
-
-namespace content {
-struct Manifest;
-class WebContents;
-}
-
-class GURL;
-struct InstallableData;
-class WebApkIconHasher;
-
-// ManifestUpgradeDetectorFetcher is the C++ counterpart of
-// org.chromium.chrome.browser's ManifestUpgradeDetectorFetcher in Java. It is
-// created via a JNI (Initialize) call and MUST BE DESTROYED via Destroy().
-class ManifestUpgradeDetectorFetcher : public content::WebContentsObserver {
- public:
- ManifestUpgradeDetectorFetcher(JNIEnv* env,
- jobject obj,
- const GURL& scope,
- const GURL& web_manifest_url);
-
- // Replaces the WebContents that is being observed.
- void ReplaceWebContents(
- JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jobject>& java_web_contents);
-
- // Called by the Java counterpart to destroy its native half.
- void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
-
- // Called by the Java counterpart to start checking web manifest changes.
- void Start(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jobject>& java_web_contents);
-
- // Registers JNI hooks.
- static bool Register(JNIEnv* env);
-
- private:
- ~ManifestUpgradeDetectorFetcher() override;
-
- // content::WebContentsObserver:
- void DidStopLoading() override;
-
- // Fetches the installable data.
- void FetchInstallableData();
-
- // Called once the installable data has been fetched.
- void OnDidGetInstallableData(const InstallableData& installable_data);
-
- // Called with the computed Murmur2 hash for the app icon.
- void OnGotIconMurmur2Hash(const std::string& best_icon_murmur2_hash);
-
- void OnDataAvailable(const ShortcutInfo& info,
- const std::string& best_icon_murmur2_hash,
- const SkBitmap& best_icon);
-
- // Points to the Java object.
- base::android::ScopedJavaGlobalRef<jobject> java_ref_;
-
- // The detector will only fetch the URL within the scope of the WebAPK.
- const GURL scope_;
-
- // The WebAPK's Web Manifest URL that the detector is looking for.
- const GURL web_manifest_url_;
-
- // The URL for which the installable data is being fetched / was last fetched.
- GURL last_fetched_url_;
-
- // Downloads app icon and computes Murmur2 hash.
- std::unique_ptr<WebApkIconHasher> icon_hasher_;
-
- // Downloaded data for |web_manifest_url_|.
- ShortcutInfo info_;
- SkBitmap best_icon_;
-
- base::WeakPtrFactory<ManifestUpgradeDetectorFetcher> weak_ptr_factory_;
-
- DISALLOW_COPY_AND_ASSIGN(ManifestUpgradeDetectorFetcher);
-};
-
-#endif // CHROME_BROWSER_ANDROID_WEBAPK_MANIFEST_UPGRADE_DETECTOR_FETCHER_H_
« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698