content/browser/web_contents/web_contents_impl.cc - Issue 246023007: Chromium-side plumbing for ServiceWorker -> Document postMessage (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 246023007: Chromium-side plumbing for ServiceWorker -> Document postMessage (2/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: message port threading fix Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/child/service_worker/service_worker_dispatcher.h » ('j') | content/renderer/service_worker/service_worker_script_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index ea872a6957b5757bd88c23c708fecf8612e542aa..df54adaf3dd02d3c6bb6bb853938c6788742f7a0 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3536,15 +3536,9 @@ void WebContentsImpl::RouteMessageEvent(

MessagePortMessageFilter* message_port_message_filter =

static_cast<RenderProcessHostImpl*>(GetRenderProcessHost())

->message_port_message_filter();

- std::vector<int> new_routing_ids(params.message_port_ids.size());

- for (size_t i = 0; i < params.message_port_ids.size(); ++i) {

- new_routing_ids[i] = message_port_message_filter->GetNextRoutingID();

- MessagePortService::GetInstance()->UpdateMessagePort(

- params.message_port_ids[i],

- message_port_message_filter,

- new_routing_ids[i]);

- }

- new_params.new_routing_ids = new_routing_ids;

+ message_port_message_filter->UpdateMessagePortsWithNewRoutes(

+ params.message_port_ids,

+ &new_params.new_routing_ids);

}

// If there is a source_routing_id, translate it to the routing ID for