Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: net/quic/core/crypto/crypto_secret_boxer.h

Issue 2460223002: Adds std:: to stl types (#049) (Closed)
Patch Set: remove dead using std::foo declarations. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/crypto_framer_test.cc ('k') | net/quic/core/crypto/crypto_server_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/crypto_secret_boxer.h
diff --git a/net/quic/core/crypto/crypto_secret_boxer.h b/net/quic/core/crypto/crypto_secret_boxer.h
index 09ec23c3613e81c366d4a3e03528c5b239c55a5c..3bc92846bc186ae066badf629454ea6aece6f7da 100644
--- a/net/quic/core/crypto/crypto_secret_boxer.h
+++ b/net/quic/core/crypto/crypto_secret_boxer.h
@@ -30,10 +30,9 @@ class NET_EXPORT_PRIVATE CryptoSecretBoxer {
// GetKeySize returns the number of bytes in a key.
static size_t GetKeySize();
- // SetKeys sets a std::list of encryption keys. The first key in the std::list
- // will be used by |Box|, but all supplied keys will be tried by |Unbox|, to
- // handle key skew across the fleet. This must be called before |Box| or
- // |Unbox|. Keys must be |GetKeySize()| bytes long.
+ // used by |Box|, but all supplied keys will be tried by |Unbox|, to handle
+ // key skew across the fleet. This must be called before |Box| or |Unbox|.
+ // Keys must be |GetKeySize()| bytes long.
void SetKeys(const std::vector<std::string>& keys);
// Box encrypts |plaintext| using a random nonce generated from |rand| and
@@ -53,7 +52,7 @@ class NET_EXPORT_PRIVATE CryptoSecretBoxer {
private:
mutable base::Lock lock_;
- // GUARDED_BY(lock_).
+ // GUARDED_BY(lock_).mutable Mutex lock_;
std::vector<std::string> keys_;
DISALLOW_COPY_AND_ASSIGN(CryptoSecretBoxer);
« no previous file with comments | « net/quic/core/crypto/crypto_framer_test.cc ('k') | net/quic/core/crypto/crypto_server_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698