Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2460213002: Revert of [promises] Move PromiseReject to c++ (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
Reviewers:
adamk, gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [promises] Move PromiseReject to c++ (patchset #9 id:160001 of https://codereview.chromium.org/2451163003/ ) Reason for revert: Causes parse and compile regressions on yahoo and ebay (cbrug/660720). Original issue's description: > [promises] Move PromiseReject to c++ > > This patch refactors most of FulfillPromise runtime call out to a separate > function so that we can to it from PromiseReject runtime call. > > This patch adds a PromiseStatus enum. > > BUG=v8:5343 TBR=adamk@chromium.org,gsathya@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -64 lines) Patch
M src/globals.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/js/async-await.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/promise.js View 6 chunks +23 lines, -20 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +9 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Camillo Bruni
Created Revert of [promises] Move PromiseReject to c++
4 years, 1 month ago (2016-10-30 15:49:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460213002/1
4 years, 1 month ago (2016-10-30 15:49:19 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-30 15:50:26 UTC) #5
Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15418)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15448)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/15383)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27555)

Powered by Google App Engine
This is Rietveld 408576698